Background color still on, even though all background colour settings are none

pgbarletta commented 2 years ago

How is this possible? I thought blockman.n04ColorComboPreset was supposed to be overridden by the following options.

But is actually the only setting that matters:

I just want to keep the borders.

Love the extension. Cheers!

leodevbro commented 2 years ago

@pgbarletta, Have you updated Blockman to the latest version (1.3.3) ?

pgbarletta commented 2 years ago

Yes, I've just downloaded it. This is my system:

Distributor ID: Neon
Description:    KDE neon User - Plasma 25th Anniversary Edition
Release:        20.04
Codename:       focal

and these are my installed extensions:

leodevbro.blockman
alefragnani.Bookmarks
xaver.clang-format
ms-vscode.cmake-tools
Shan.code-settings-sync
ms-vscode.cpptools
ms-vscode.cpptools-themes
ms-toolsai.jupyter
ms-toolsai.jupyter-keymap
ms-toolsai.jupyter-renderers
julialang.language-julia
yzhang.markdown-all-in-one
nvidia.nsight-vscode-edition
ms-python.python
ms-vscode-remote.remote-containers
ms-vscode-remote.remote-ssh
ms-vscode-remote.remote-ssh-edit
Equinusocio.vsc-material-theme
equinusocio.vsc-material-theme-icons
kamikillerto.vscode-colorize
ms-azuretools.vscode-docker
singularitti.vscode-julia-formatter
ms-python.vscode-pylance
ms-vscode-remote.vscode-remote-extensionpack
wayou.vscode-todo-highlight
VisualStudioExptTeam.vscodeintellicode

leodevbro commented 2 years ago

So, if I understand correctly, you want also the focused block background to be off? Please try this: "blockman.n17CustomColorOfFocusedBlock": "none",

pgbarletta commented 2 years ago

oohhh, now I get it. But if I do that, I loose the borders too. I thought "Color" meant background color. It'd be nice to be able to just keep the borders, but I can totally manage now.

Thank you for such a quick answer.

leodevbro commented 2 years ago

lose borders? No, the borders will be still there. Please copy all your Blockman settings here, so I can see the cause of your issue.

pgbarletta commented 2 years ago

Loosing borders:

"blockman.n04ColorComboPreset": "Classic Light (Super gradients)",
    "blockman.n05CustomColorOfDepth0": "#none",
    "blockman.n06CustomColorOfDepth1": "#none",
    "blockman.n07CustomColorOfDepth2": "#none",
    "blockman.n08CustomColorOfDepth3": "#none",
    "blockman.n09CustomColorOfDepth4": "#none",
    "blockman.n10CustomColorOfDepth5": "#none",
    "blockman.n11CustomColorOfDepth6": "#none",
    "blockman.n12CustomColorOfDepth7": "#none",
    "blockman.n13CustomColorOfDepth8": "#none",
    "blockman.n14CustomColorOfDepth9": "#none",
    "blockman.n15CustomColorOfDepth10": "#none",
    "blockman.n17CustomColorOfFocusedBlock": "none",
    "blockman.n18CustomColorOfFocusedBlockBorder": "black",
    "blockman.n19CustomColorOfBlockBorder": "black",
    "blockman.n20CustomColorOfDepth0Border": "black"

with borders:

"blockman.n05CustomColorOfDepth0": "#none",
    "blockman.n06CustomColorOfDepth1": "#none",
    "blockman.n07CustomColorOfDepth2": "#none",
    "blockman.n08CustomColorOfDepth3": "#none",
    "blockman.n09CustomColorOfDepth4": "#none",
    "blockman.n10CustomColorOfDepth5": "#none",
    "blockman.n11CustomColorOfDepth6": "#none",
    "blockman.n12CustomColorOfDepth7": "#none",
    "blockman.n13CustomColorOfDepth8": "#none",
    "blockman.n14CustomColorOfDepth9": "#none",
    "blockman.n15CustomColorOfDepth10": "#none",
    "blockman.n17CustomColorOfFocusedBlock": "#ffffff",
    "blockman.n18CustomColorOfFocusedBlockBorder": "black",
    "blockman.n19CustomColorOfBlockBorder": "black",
    "blockman.n20CustomColorOfDepth0Border": "black"

The only change I made was from:

"blockman.n17CustomColorOfFocusedBlock": "none",

to:

"blockman.n17CustomColorOfFocusedBlock": "#ffffff",

leodevbro commented 2 years ago

#none is wrong value. Please remove the # (hash symbol). If still not solved, please restart VSCode and then make sure that Blockman version is truly 1.3.3.

pgbarletta commented 2 years ago

Done and restarted VSCode.

"blockman.n05CustomColorOfDepth0": "none",
    "blockman.n06CustomColorOfDepth1": "none",
    "blockman.n07CustomColorOfDepth2": "none",
    "blockman.n08CustomColorOfDepth3": "none",
    "blockman.n09CustomColorOfDepth4": "none",
    "blockman.n10CustomColorOfDepth5": "none",
    "blockman.n11CustomColorOfDepth6": "none",
    "blockman.n12CustomColorOfDepth7": "none",
    "blockman.n13CustomColorOfDepth8": "none",
    "blockman.n14CustomColorOfDepth9": "none",
    "blockman.n15CustomColorOfDepth10": "none",
    "blockman.n17CustomColorOfFocusedBlock": "none",
    "blockman.n18CustomColorOfFocusedBlockBorder": "black",
    "blockman.n19CustomColorOfBlockBorder": "black",
    "blockman.n20CustomColorOfDepth0Border": "black"

leodevbro commented 2 years ago

[UPDATE]: Now I reproduced it in my VSCode. It works fine on VSCode Insiders, but not in VSCode. So now I'm trying to find the cause of the issue.

leodevbro commented 2 years ago

Well, yeah, I think it's not a bug of Blockman, but it's a bug of VSCode, because it works fine in VSCode Insiders. I'll try to find exact cause of this problem.

pgbarletta commented 2 years ago

last vscode release was on october, I'm guessing the bug fix might be around the corner.

pgbarletta commented 2 years ago

by the way, the new update did fix it. So it's all good now.

leodevbro / vscode-blockman

Background color still on, even though all background colour settings are none #56