search

leodido / postcss-clean

PostCss plugin to minify your CSS with clean-css
MIT License
41 stars 8 forks source link

Version 1.2.0 is breaking #50

Closed lmestel closed 3 years ago

lmestel commented 3 years ago

Hi, thanks for this great package! We use it for years!

But i think, moving to PostCSS 8 in version 1.2.0 was a breaking change. We have a PostCSS 7 based gulp-postcss task, that breaks after npm install with Error: PostCSS plugin clean requires PostCSS 8.. With "postcss-clean": "^1.1.0" in our package.json NPM loads version 1.2.0 (believing a feature release won't break existing code).

Is it possible to make postcss-clean backwards compatible to PostCSS 7?

Thanks, Lukas

lmestel commented 3 years ago

Another solution may be to revert the changes, publish that to version 1.2.1 and republish 1.2.0 to version 2.0.0 So that 1.1.0 === 1.2.1 and 1.2.0 === 2.0.0

leodido commented 3 years ago

You're right. My wrong. That should have been 2.0.0.

leodido commented 3 years ago

Another solution may be to revert the changes, publish that to version 1.2.1 and republish 1.2.0 to version 2.0.0 So that 1.1.0 === 1.2.1 and 1.2.0 === 2.0.0

Going with this.

leodido commented 3 years ago

Ok, waiting for Travis to do the job.

leodido commented 3 years ago

@lmestel ok Lukas, here it is: https://www.npmjs.com/package/postcss-clean/v/1.2.1

Can you please let me know if it's ok for you folks now? Tnx

lmestel commented 3 years ago

Everything works again 👌 Thank you very much!

julianlam commented 3 years ago

Wait, so this plugin isn't compatible with postcss@8 now? I think that may be a regression.

Our builds are failing with the following error:

TypeError: node.getIterator is not a function
    at LazyResult.visitTick (/home/runner/work/NodeBB/NodeBB/node_modules/postcss/lib/lazy-result.js:484:33)
    at LazyResult.runAsync (/home/runner/work/NodeBB/NodeBB/node_modules/postcss/lib/lazy-result.js:372:30)
    at process._tickCallback (internal/process/next_tick.js:68:7)

We've been on postcss@8 for 3+ months, running postcss-clean@1.1.0.

leodido commented 3 years ago

Hello Julian, I have the support for postcss8 in a local branch. Will publish and release it soon

On Wed, 3 Feb 2021 at 21:39 Julian Lam notifications@github.com wrote:

Wait, so this plugin isn't compatible with postcss@8 now? I think that may be a regression.

Our builds are failing with the following error:

TypeError: node.getIterator is not a function at LazyResult.visitTick (/home/runner/work/NodeBB/NodeBB/node_modules/postcss/lib/lazy-result.js:484:33) at LazyResult.runAsync (/home/runner/work/NodeBB/NodeBB/node_modules/postcss/lib/lazy-result.js:372:30) at process._tickCallback (internal/process/next_tick.js:68:7)

We've been on postcss@8 for 3+ months, running postcss-clean@1.1.0.

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/leodido/postcss-clean/issues/50#issuecomment-772807186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5J45HV3DNV66P2C7GGD3S5GX7VANCNFSM4WOWTGSQ .

-- L.

leodido commented 3 years ago

Hey, in the branch release/2.x there's support for postcss 8. Would you give it a try pls?

I plan to also bump clean-css to version 5 and then release it as version 2.0 L.

On Wed, Feb 3, 2021 at 11:41 PM Leonardo Di Donato leodidonato@gmail.com wrote:

Hello Julian, I have the support for postcss8 in a local branch. Will publish and release it soon

On Wed, 3 Feb 2021 at 21:39 Julian Lam notifications@github.com wrote:

Wait, so this plugin isn't compatible with postcss@8 now? I think that may be a regression.

Our builds are failing with the following error:

TypeError: node.getIterator is not a function at LazyResult.visitTick (/home/runner/work/NodeBB/NodeBB/node_modules/postcss/lib/lazy-result.js:484:33) at LazyResult.runAsync (/home/runner/work/NodeBB/NodeBB/node_modules/postcss/lib/lazy-result.js:372:30) at process._tickCallback (internal/process/next_tick.js:68:7)

We've been on postcss@8 for 3+ months, running postcss-clean@1.1.0.

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/leodido/postcss-clean/issues/50#issuecomment-772807186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5J45HV3DNV66P2C7GGD3S5GX7VANCNFSM4WOWTGSQ .

-- L.

dimitrinicolas commented 3 years ago

I've just tried your release/2.x branch on my personal project with a PostCSS 8 config and it works wonderfully on my side!