search

leoding86 / pixiv-omina

Pixiv Omina is a software for downloading artworks and comics from Pixiv and Pixiv Comic
Mozilla Public License 2.0
283 stars 26 forks source link

Cannot read property 'illustration','manga' of undefined #55

Closed sakkamade closed 3 years ago

sakkamade commented 3 years ago

Omina Version

0.7.5

What's the problem

Clicking the Omina button in browser before the page being loaded results in Cannot read property 'illustration' of undefined. And after such error, even if I reload the page properly and click the button again, or manually parse the link, Pixiv Omina would not download artwork until the errored item will be deleted from Pixiv Omina (red trash bin button).

Screenshot-omina-error

Extra info

Browser (Firefox) showed such error page in previous versions as well, however Pixiv Omina downloaded the image without any issues.

leoding86 commented 3 years ago

Issue has been located. Fix it in next version.

sakkamade commented 3 years ago

@leoding86 , I'll ask just to make sure. The links for manga doesn't work, at all. Is that fixed as well?

Update: Error looks similar - Cannot read property 'manga' of undefined, but in this case it appears to be impossible to download it.

leoding86 commented 3 years ago

@sakkamade I just fix it in source code. So you need to wait binary release for using 'Omina' button in browser.

sakkamade commented 3 years ago

@leoding86 Yeah, I understand that. But, the manga doesn't downloading even via parsing a link into Pixiv Omina. There's completely no way to download manga, at least for me. So I was wondering if that another, unrelated issue.

leoding86 commented 3 years ago

Issue confirmed. It's a related issue, I'll release a new version asap.

sakkamade commented 3 years ago

Well, it is urelated, since it wasn't as yet fixed .

leoding86 commented 3 years ago

Try version 0.7.6. The issues have been fixed, I think.

sakkamade commented 3 years ago

Either way, 0.7.6 seemed to fix everything. Closing it.

@leoding86 , Yes, they were.