leoding86 / webextension-pixiv-toolkit

A web extension for Pixiv
1.46k stars 88 forks source link

Deps: Replace node-sass with sass #136

Closed LDSpits closed 3 years ago

LDSpits commented 3 years ago

(note: this pull request is based on branch feature, since this seems to be the branch with the latest changes)

Node-sass has been deprecated in 2020 in favor of a new dart-sass compiler implementation. This pull request replaces the dependency with the dart implementation.

Doing this removes the dependency on node-gyp and thus python2. which makes building this project now a lot easier (I had trouble getting node-sass to build on Ubuntu).

We needed to fix a single deprecation error from the dart compiler (https://sass-lang.com/documentation/at-rules/extend#disallowed-selectors). This fix did not have any visible effect (subtitles are still grey) which I confirmed in a Firefox build.