leoding86 / webextension-pixiv-toolkit

A web extension for Pixiv
1.46k stars 89 forks source link

Stuck on "downloading" on ugoira #16

Closed karasawa-user closed 4 years ago

karasawa-user commented 4 years ago

Is there any way to know how far this extension downloading ugoira data before download menu available or at least indicator of it working on something? It seems never completed on some ugoiras and I really can't tell reloading the addon really fix the issue. Here's the sample work that keep stuck at downloading no matter what I do: https://www.pixiv.net/en/artworks/73031132

I using vivaldi 2.9.1705.41 and firefox 61.0.2 on windows 10 Screenshot_2019-12-03 cowgirl position, creampie, Yuzuki Yukari 結月ゆかりS○XROID版 - pixiv

leoding86 commented 4 years ago

Downloading means the extension is downloading the resources, I'm pretty sure it caused by slow network.

The Pixiv uses fetch api to get resources data and the api can't tell the download progress. I tried to use xhr to request resources, but after several tries there was no luck.

I could use response.body property, it's a ReadableStream, to computed the progress. It's not widely supported but I'll give it a try later.

karasawa-user commented 4 years ago

I afraid it's not caused by slow network because some long ugoiras downloaded pretty fast... But just in case, is "wrong IP" case could happen in this addon? If that so then it's still my net's fault

leoding86 commented 4 years ago

I tried the url in vivaldi (2.9.1705.41), the extension works fine. Could you screenshot the red lines in the Console of DevTools of the browser. It will display more infomations I need to investigate the issue. I haven't updated the addon on Firefox for a long time. I can't make sure the addon on Firefox will works as expected.

karasawa-user commented 4 years ago

Somehow link above managed to be downloaded today, this from different work, https://www.pixiv.net/en/artworks/75954856

2019-12-04 13 42 14-dbfa1792a830_n 2019-12-04 13 43 57-fa7b1be32418_n

karasawa-user commented 4 years ago

And this is from firefox side, this extension can't work if tracking protection is on so I turn it off first 2019-12-04_14-00-36

leoding86 commented 4 years ago

It seems like the extension has been interrupted by something to make the fetch api cannot fetch data properly. I need to do some test work to find what's going on.

leoding86 commented 4 years ago

Still have no idea what‘s caused this. Will add a retry button after download is interrupted. Update in next version.