leoding86 / webextension-pixiv-toolkit

A web extension for Pixiv
1.46k stars 89 forks source link

Rename file doesn't work #258

Closed nemesiscompletion closed 3 months ago

nemesiscompletion commented 3 months ago

Describe the bug I'd like the downloaded pics to have same name as when I'd download them manually by saving the images with right click So, I wanted to download them with ID and page number on each files However, it's keep downloading files with random names like this 0fffc225-afaa-49f1-817c-0610dc1fe28a f9e1f493-4869-4421-a082-8f633afa824b 06b18c0b-8307-4cf5-bf27-7d3dd3347f20 981508af-1871-4344-930a-4e06511514e5

Expected behavior The file name has to show ID for the images and page number, just like the file name that shows if I'd manually download them

Example work from Pixiv For example, if I'm to download first image from this page https://www.pixiv.net/artworks/39602552 The file name is supposed to be 39602552_p0.jpg However, when I use the application, the file name appears like this 656cff7e-4323-4c01-9732-9931db60289a.jpg

Screenshots Here's example for both, first one is manually downloaded Second one is downloaded by application 39602552_p0 656cff7e-4323-4c01-9732-9931db60289a 20240815_033748

Browser and Version (please complete the following information): Chrome 127.0.6533.101

Settings of extension pixiv_toolkit_settings-1723707537702.json

Additional context I tried changing rename settings but it just keep shows some random names

leoding86 commented 3 months ago

Could you provide the extension version?

leoding86 commented 3 months ago

@nemesiscompletion I can't reproduce the problem, need further information. Snipaste_2024-08-16_23-10-54 Snipaste_2024-08-16_23-12-00 Snipaste_2024-08-16_23-12-08

leoding86 commented 3 months ago

@nemesiscompletion I tested with different settings, nothing wrong happened. Snipaste_2024-08-16_23-10-54 Snipaste_2024-08-17_00-31-07

nemesiscompletion commented 3 months ago

I'm using this version 6.3.1 and settings are like this at the moment 20240816_133408 20240816_133422

I'm still getting random names for the pics like this 20240816_133716 Also, even for the same pics, it changes names randomly every time I download them

DGCO commented 3 months ago

I encountered the same issue, it also packs everything into a zipped file even if there is only one image to be downloaded. And it is not identifying downloaded images now.

leoding86 commented 3 months ago

The problem is I can't repro this issue. I tested in Chrome and Edge, the renaming is working fine.🤔

DDDDDuang commented 3 months ago

我这边在6.0更新后也遇到了相同的问题,之前重命名是可以正常工作的。 不过我尝试关闭了Chrono下载管理器之后可以正常重命名下载了,可能是这两个插件之间某些功能发生了冲突。

具体原因我不太好定位,不过还是希望能同时使用这两个插件(毕竟之前是可以的,Chrome原生的下载管理器太难用了)。 如果能解决的话真的非常感谢,6.0更新之后我的pixiv下载流畅度还是有很大改善的,辛苦了。

Pamlau commented 3 months ago

same problem here

DGCO commented 3 months ago

The problem is I can't repro this issue. I tested in Chrome and Edge, the renaming is working fine.🤔

I have an assumption, maybe this is a problem caused by having multiple extensions that have the rename permission. I have other image downloaders on my Chrome, is that possible to check on that?

In this example [https://www.pixiv.net/artworks/39602552] I will get a random name zip file and normal filename inside the zip file like p0 - p5.

leoding86 commented 3 months ago

@DGCO Could you provide another extension you use?

leoding86 commented 3 months ago

@DDDDDuang 这个Chrono下载管理器?如果是的我可以先试试能不能浮现问题。

SWN-002 commented 3 months ago

回報一下,我沒有安裝上述的Chrono下載管理器,也將我所有可能與下載管理有關的擴充(僅安裝Free Download Manager以及Down Them All)移除或停用,問題依舊

DDDDDuang commented 3 months ago

@DDDDDuang 这个Chrono下载管理器?如果是的我可以先试试能不能浮现问题。

是的,我禁用插件之后重命名可以正常工作

leoding86 commented 3 months ago

@DDDDDuang @SWN-002 刚才看了下文档,可能是chrome.downloads.onDeterminingFilename这个接口调用抢占的问题。当前插件并没有调用此接口,目前没有完美的办法来解决,如果安装的其他扩展调用此接口的优先级更高那么就没有任何办法复写名称。我先尝试处理下。

技术细节在这里

DGCO commented 3 months ago

@DGCO Could you provide another extension you use?

Sure. Imageye 圖片助手(ImageAssistant) 批量圖片下載器 Image Downloader

Edited: I see this turn into closed. Thanks for following up on this issue. I am looking forward to the update.