Implement ISG - Githubissues

leoetlino / project-restoration

A Majora's Mask 3D patch that restores some mechanics from the original game to get the best of both worlds

https://zora.re/storation

GNU General Public License v2.0

693 stars 24 forks source link

Implement ISG #188

Closed PhlexPlexico closed 3 years ago

PhlexPlexico commented 3 years ago

I saw this feature being asked for by a few people. Since it shouldn't directly interfere with gameplay, unless specifically activated (pickup item while shielding and swinging). I've checked both on patched and non-patched versions of the game to see if this implementation works, and they both had the same expected behaviour (8 slashes with kokiri sword to kill Gibdos). It appears that this implementation should not impact any regular game play.

leoetlino commented 3 years ago

Whoops, sorry for forgetting about this! Has the relative branch been tested? I don't really have enough time to test changes so I'll trust you and merge if this has been tested after you converted the branches into relative jumps

PhlexPlexico commented 3 years ago

Aside from the comma existing instead of a period, I did test it once more and it seemed to pass all my cases. A few are listed:

Make sure it can't be triggered through regular sword swinging/unintentionally.
Other forms don't cause UB or crashing.
Damage is still the same on crouch stabs/slashes/etc.

I believe this should be good to go!