leofarage / connectbot

Automatically exported from code.google.com/p/connectbot
Apache License 2.0
0 stars 0 forks source link

[PATCH] Adjustments to behavior of bell-vibrate feature #208

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Reasonable people will probably disagree on this patch, but I'm going to throw 
it out there for 
opinions.

1) The feedback-vibration used for the trackball and pgup/pgdn keys (30 ms) is 
way too short 
for a notification buzz. This patch splits out the two durations, and defaults 
the buzz-on-bell to 
150 ms. (I personally like it at 500, but I think that will be an uncommon 
preference. :-)

2) It seems to me that most of the point of the buzz-on-bell, whose purpose is 
to get my 
attention, is lost if it only works in the foreground! The patch removes the 
test for 
foregroundness, and has the buzz activate any time a bell is seen. This does 
not change the 
behavior of the notification option, just the vibration.

I probably shouldn't have put these in the same patch; I think (1) should 
definitely go in, and (2) 
may get argued over. If in doubt, it's easy to remove (2) -- it's a very short 
patch.

Original issue reported on code.google.com by gwillen@gmail.com on 21 Oct 2009 at 7:01

GoogleCodeExporter commented 8 years ago
It doesn't seem particularly good to vibrate even when you're in the background.
Can't you just set notifications to vibrate when they pop up in the 
notifications tray?

Original comment by kenny@the-b.org on 25 Oct 2009 at 4:59

GoogleCodeExporter commented 8 years ago
I would also like connectbot to buzz/vibrate when in the background, I hate 
having to keep checking the notification bar to see if my finch session has 
received a new message. 

Original comment by drew.kirkpatrick on 23 Jun 2010 at 1:13