leofuturer / eDrops3

The 3rd generation of the eDrops web application.
MIT License
0 stars 0 forks source link

Fixes a lot of open issues #105

Closed Kenny477 closed 1 year ago

Kenny477 commented 1 year ago

Pull request addresses large issues like order chat and also some of the smaller issues.

leofuturer commented 1 year ago

@cmchoi220 Could you pull this branch to test and see if everything works as expected? @skuiry Could you test the chatting feature since you are quite familiar with the workflow Thank you!

leofuturer commented 1 year ago

When I tried to run the App on localhost, it seems that it has some Pusher issues:

image

@cmchoi220 @skuiry I wonder if you run into a similar issue when you tested? Or perhaps I miss something when set up.

Kenny477 commented 1 year ago

@leofuturer I believe @cmchoi220 experienced the same issue. I looked into it and it seems like the reason is that you may not have the Pusher API key in your environment variables.

Check the Google Drive for the env files if you do not have the key.

leofuturer commented 1 year ago

I just checked the file on Shared Google drive. The backend.env seems to be using the service@edrops.org. I thought that would be an outdated version of the env file. Could you confirm it is the most updated one that we should use?

Also, I found the APP_EMAIL_API_KEY for service@edrops.org in the file (on the shared drive) is the same as the one in my current .env file for info@edroplets.org. I wonder if both emails share the same API key or is it a mistake?

Kenny477 commented 1 year ago

I'll reupload the entire env var folder to Google Drive to make sure it is up to date @leofuturer

leofuturer commented 1 year ago

Sounds good. Please let everyone know once you reupload.

Kenny477 commented 1 year ago

Sounds good. Please let everyone know once you reupload.

It's been completed.

leofuturer commented 1 year ago

When I was testing, I found that there are some errors showing up whenever I refresh the page (seems to happen to every page)

https://user-images.githubusercontent.com/40692943/235555058-fa3fc482-54ea-48d7-afef-032976c848e0.mp4

leofuturer commented 1 year ago

The adding-to-cart feature seems to have some problems. After adding an item to the cart, I have to refresh the page to see the updated cart.

https://user-images.githubusercontent.com/40692943/235555742-ecf241b3-cb03-4f07-b52c-961d21432d7b.mp4

Kenny477 commented 1 year ago

When I was testing, I found that there are some errors showing up whenever I refresh the page (seems to happen to every page)

20230501_173148.mp4

I think this is because you don't have the React DevTools extension on Chrome. Not sure why it results in the errors exactly, but I don't think the errors actually mean anything.

Kenny477 commented 1 year ago

The adding-to-cart feature seems to have some problems. After adding an item to the cart, I have to refresh the page to see the updated cart.

20230501_173921.mp4

Adding to cart works fine for me on both Microsoft Edge and Google Chrome.

cmchoi220 commented 1 year ago

When deleting items from the cart, sometimes I can see a "0" appear above or below the list of items. This corresponds to if I have 0 products and nonzero chips, or vice versa. This corresponds to page/cart/index.tsx lines 28 and 34. I believe explicitly checking for 0 (and undefined) fixes this.

https://user-images.githubusercontent.com/52839515/235818379-f7cf8263-f2d7-44dc-8e26-10305d5b61eb.mp4

Additionally, I was trying to check out when I would get an error when I clicked "Proceed to Payment". Console says customer.user is undefined. This occurred with the built-in and my own account.

image

Kenny477 commented 1 year ago

For the second issue @cmchoi220 do you have the latest version of the docker image? i.e. did you make sure to rebuild it?

cmchoi220 commented 1 year ago

@Kenny477 I ran the docker:build shortcut, but I think I just needed to run the other build commands as well.

cmchoi220 commented 1 year ago

I noticed that when the admin views the chat between a foundry worker and customer, both people's messages appear on the left and are indistinguishable.

Worker POV: image

Customer POV: image

Admin POV: image

Kenny477 commented 1 year ago

I noticed that when the admin views the chat between a foundry worker and customer, both people's messages appear on the left and are indistinguishable.

Worker POV:

image

Customer POV:

image

Admin POV:

image

Yes, this was mentioned during the meeting and a fix is planned. Mostly we just need to identify and record the worker/customer in a given order conversation so admins can differentiate.

Kenny477 commented 1 year ago

I'm going to merge this for the sake of clarity and cleaning up issues. Ideally we fix everything that might be buggy in this branch before the merge, but we can address that in later issues/PRs.