search

leofuturer / eDrops3

The 3rd generation of the eDrops web application.
MIT License
0 stars 0 forks source link

Fix/cart issues & address community site #119

Closed Kenny477 closed 10 months ago

Kenny477 commented 1 year ago

Opening PR to track progress

leofuturer commented 1 year ago

I am testing using the deployed version: edroplets.org issue 1) Looks like the "Return to Cart" button below directs the user to the login page:

image
leofuturer commented 1 year ago

Question: for the new email account verification after signing up, it seems that when I click the email verification link, it directly goes to the login page. In the past, we had a page that reminds the user about email verification successful, where they can click a button to go to the login page. I wonder why we removed that page now?

leofuturer commented 1 year ago

issue 2) the cart seems still not automatically becomes empty after checking out. The cart can not become empty even I refresh the page. And it seems that the new order was not created in the order/fab order list.

For the "cart does not become empty after checkout" issue, it has been here for a while, which makes me think that we may just not create a separate tab for checkout, i.e., let user stay in the same tab for checkout & allow user to go back to the main site using a "Go back to eDroplets" button. Will this be a simpler and more straightforward way to resolve the issue?

Besides, now we are using the "eDrops" in the checkout confirmation page, which seems not clear enough for user to understand it as a button to go back to the main site. How about changing to "Go to eDroplets"?

leofuturer commented 1 year ago

For the community site: 1) the sign up seems not working 2) Please fix the broken image issue. I will likely need it for a figure for our journal paper soon

Kenny477 commented 1 year ago

@leofuturer Got it. I'll work on fixing those issues and have already fixed some of them. The redirect ones (i.e. going to login instead of back to cart, and not going to the email verified page) are because I shortened some of the route names to be more concise/readable and forgot to change them in some places.

For the production instance, I will test if the webhook is setup properly on AWS to see if that is maybe causing the issue. If I recall, it was working on local. Either way, I'll investigate it.

I'll fix the remaining touchups (i.e. community button on main site should work now, fixing the image on community site, etc.).

leofuturer commented 1 year ago

@Kenny477 Sounds good. I will test on local as well

leofuturer commented 1 year ago

Just tested on local. Most issues seem to be fixed. Let's merge this PR and I will create new issues, which we can resolve in a separate PR