Closed Kenny477 closed 1 year ago
Addresses
There are a few things to improve: for those I marked as [This deploy], let's fix them before this deployment. For those I marked as [later], we can open issues, and let's fix them after this deployment. In general, I found that the CSS has changed a lot.
[This deploy] We should change all the eDrops to eDroplets (using the whole picture logo) & also fix all the links in the email template. And please remove "Edrop Inc" here (shown below):
[This deploy] The topbar seems to lack some responsiveness. I am using a 16:10 display, which shows this issue when zoomed to be 100%
A similar issue occurs with the products (still zoomed to 100%). Looks like the white margin on the left and right is so large that the content in the center is squeezed
Similar issues with these two products. Looks like the white margin on the left and right is so large that the content in the center is squeezed
For all these UI issues above, please refer to what we currently have on edrops.org, which looks pretty good.
[This deploy] some essential UI changes, please refers to the slides here: https://docs.google.com/presentation/d/1yPlXoI1Kh5X7Cwq5W0xLm7anTq-d3OFX/edit?usp=share_link&ouid=118174241976747621300&rtpof=true&sd=true
[This deploy] The order list seems to show an order in progress. Please change it to just show something like "You currently don't have any order". The same should apply to the Fab order
[This deploy] Some information (Street, State, Zip code) is not added to the profile page or the default address after signing up for the account.
[Later] The form checks for the password strong or not is missing. We should add that back later
@leofuturer For the "Products" text on the main page, I changed it to be orange as all other heading texts throughout our website are orange. It was originally blue, but the heading text for our dashboard pages, our products page, signup, login, etc. are all orange, so I changed it to that.
@leofuturer This might not be necessary now, but if we have top-down pictures of the control system and control system inspection board, I can photoshop out the table background to make the background just plain white/transparent.
See below. Let me know if you think this looks nicer. I have to do some Photoshop anyways because the pcb chip image is not a square image and I need to resize it.
This is what it looks like on the Products page.
@leofuturer For the "Products" text on the main page, I changed it to be orange as all other heading texts throughout our website are orange. It was originally blue, but the heading text for our dashboard pages, our products page, signup, login, etc. are all orange, so I changed it to that.
Understood. The orange is fine for now.
@leofuturer This might not be necessary now, but if we have top-down pictures of the control system and control system inspection board, I can photoshop out the table background to make the background just plain white/transparent.
See below. Let me know if you think this looks nicer. I have to do some Photoshop anyways because the pcb chip image is not a square image and I need to resize it.
The white is better for the PCB chip since the PCB chip has a bright color. However, I'm not sure how it looks for the control system. Here's a picture of the control system (with the PCB chip installed) I processed using photoshop a few weeks ago: https://drive.google.com/file/d/1BCRIpELB-BVGVzQ7m0vHLHTI__2buZ2O/view?usp=share_link. Since the control system has a silver color, I picked the grey background, which also applies to the PCB chip picture I sent to you to be consistent. You can try some different colors if you think others are better.
For the inspection board, I will take a picture in the lab tomorrow and send to you.
Whatever color we use, try to make them consistent. Regarding the size of these three pictures, it would be better if you can make them have same size too.
@leofuturer I've fixed all the issues you mentioned
Excellent! Thank you, Kenneth. One more issue: please remove these 3 links (website, Email, Community) in the verification email :
These seem not to work.
Besides, if you have time, could you also change the pictures for the control system & inspection board as well: Here are links for the .psd file (I removed the background so that you can change the background color to white or grey, whatever you think is better): https://drive.google.com/file/d/1BCRIpELB-BVGVzQ7m0vHLHTI__2buZ2O/view?usp=share_link https://drive.google.com/file/d/1r6TOEblwkz4uO68Clo5NrMVOLgBlrsQD/view?usp=share_link We just need the background color and size of these 3 pictures to be consistent.
@leofuturer I fixed the SendGrid email templates and also updated photos. I think everything is adjusted now, so please let me know if we can merge to stage then master.
Great! Let's merge into the master and deploy this version
@leofuturer Please test on this PR. Everything should be working.
Email used for verification and other purposes is now info@edroplets.org (note that you need to change your environment variable APP_EMAIL_USERNAME to info@edroplets.org for this change to work).
All text with eDrops is now eDroplets.
And I added a toggle to our cart context to disable or enable the cart. Right now on this PR it should set enabled to false so the cart is disabled.