search

leofuturer / eDrops3

The 3rd generation of the eDrops web application.
MIT License
0 stars 0 forks source link

Stage -> master for next deploy #96

Closed Kenny477 closed 1 year ago

Kenny477 commented 1 year ago

@leofuturer

github-actions[bot] commented 1 year ago

I see you opened or edited a PR to merge into master. Please make sure that you are merging into the stage branch unless you really intend to merge into master. Thanks!

leofuturer commented 1 year ago

Looks like some cypress tests failed. Please fix them.

Kenny477 commented 1 year ago

@leofuturer We never found time to implement robust testing for the app, I only added the framework so we can add tests in the future. So please disregard the tests as most of them were just testing if the login input worked, but they used the CSS selector to select the input, which have now changed since we implemented Tailwind.

Thus the tests fail even if some functionalities work because we have changed the app.

When we have the time, we need to rewrite existing tests to fit our new design and add new tests to cover more features as well.

leofuturer commented 1 year ago

Understood.