Suggested changes

[DaanBiesterbos]

Hi there! :-)

Thanks for your bundle. I have made some adjustments to make the bundle a better fit for me, and I thought it would be nice to share the changes with you. Can you look into the PR and let me know if this is something you would like to merge? I did add some tests, I am willing to add some more if you want to merge this.

Most changes are backward compatible. The most important changes I can think of are:

• Added support for pagination links for google
  • Improved opengraph support
  • Refactored "Resource" interfaces
  • Support empty values in configuration, more specifically: I had a problem before, if I set a default title and description, I must also set a default value for canonical. This is a dangerous thing because you might no always want to set a canonical URL, or you might forget to add it. Adding a field without a default value was not allowed, and not adding the field would prevent the canonical URL from being rendered even if I set it dynamically in the controller. So, in my opinion it is better to allow empty values but avoid rendering tags when the value is null.
  • Support for multiple values. When the value is an array, we can either render one metatag for each value (see for example opengraph specs on og:locale:alternate) or render a tag with a number of comma separated values.

P.S. I am going to test this some more this week as I implement the bundle in my project. Please let me know if you are interested in merging this, but please wait with merging until the end of this week. Just in case I find something that the tests do not cover yet.)

[DaanBiesterbos]

Will close PR for now, need to move some stuff to private repo and due to conflicts with 2.8 dependencies and changes to composer.json I have to make some changes that can' t be merged. Please do look at the code though.

[leogout]

Hi, thanks for your contribution, I'll look into it when I have time ! I'm looking forward to hear from you :-)