search

leoherzog / WundergroundStationForwarder

🌦️ Google Apps Script code to send your weather station data to Wunderground, Windy, PWSWeather, Weathercloud, OpenWeatherMap, WindGuru, and/or CWOP
42 stars 6 forks source link

Windguru API accepted units for wind speed #13

Closed gingibash closed 11 months ago

gingibash commented 1 year ago

Windguru API accepts only knots as units for wind speed

leoherzog commented 1 year ago

Thanks for your pull request!

I'm currently using knots when I send data to WindGuru.

https://github.com/leoherzog/WundergroundStationForwarder/blob/v2.3.0.1/code.gs#L697-L698

As far as Wind Lull goes, we'd want to have each of the services that we pull from cache that reading, if there is one... I just went through the API docs for each of the other services and it doesn't look like Wunderground, MyAcurite, WeatherLink, or Ambient Weather have lull. I guess only Tempest has it.

gingibash commented 1 year ago

@leoherzog weatherflow API always givea data in SI units, which for wind speed is meters per second. Added function to convert m/s to knots.

leoherzog commented 12 months ago

Yeah. I've been using "mps" to mean "meters per second", and each of the five data sources has an "mps" and "mph". It looks like I'm missing Knots from a couple of the data sources. So the real goal of this pull request should be to add Knots to the data sources where it's missing.

According to the WindGuru documentation, they take in wind speed in Knots.

leoherzog commented 12 months ago

I just added the missing knots values in 7510205bd6f4509ca88af8f9d1f08aa30c45badf. Does this fix the issue that you were trying to solve with this PR @gingibash?

leoherzog commented 11 months ago

I think that the problems that @gingibash was having have been addressed by adding the missing knots values in https://github.com/leoherzog/WundergroundStationForwarder/commit/7510205bd6f4509ca88af8f9d1f08aa30c45badf. I'll be closing this Pull Request, but feel free to comment if this is incorrect and we need to re-open. Thanks again for bringing this to my attention.