search

leolabs / ableton-js

Control Ableton Live with Node.js
MIT License
368 stars 46 forks source link

:bug: Fix get_ and set_ prefix loop in __getattr__ #17

Closed shahyar closed 4 years ago

shahyar commented 4 years ago

Apologies for the pull request spam for this method. I haven't written python in a long time. This should avoid further problems with the magic of get_prop and setprop attempting to prepend get and set_, respectively.

leolabs commented 4 years ago

Haha, all good :)

I'll test the whole thing thoroughly this evening before merging and will publish a new version of AbletonJS then.

leolabs commented 4 years ago

Hey @shahyar,

Sorry that it took a bit longer than expected. I ran across a few more problems with the new changes so I chose another approach to this (see Interface.py).

This should solve all issues. In the future, I'm planning to add support for more commands out of the box, without the need to call sendCommand manually, but your PR has helped greatly in cleaning up the Python side of this project 👍

leolabs commented 4 years ago

I forgot to mention, the new release is a pre-release for now as I want to be 100% sure the changes don't introduce any problems. You can install it by running npm i ableton-js@next or yarn add ableton-js@next.