search

leolabs / ableton-js

Control Ableton Live with Node.js
MIT License
368 stars 46 forks source link

Reconnecting to Ableton fires unexpected events #41

Closed zoetrope69 closed 1 year ago

zoetrope69 commented 2 years ago

When I disconnect and reconnect Ableton I get the following events:

I looked into the JS code further and it seem like it may be a bug in the Python midi-script or further up as this is what I see in the raw messages coming into the handleIncoming.

I am using:

zoetrope69 commented 2 years ago

I'm happy to try and fix but my Python is rusty so opening a issue first incase this is just to do with my (shitty M1 chip/Monterey) setup.

zoetrope69 commented 2 years ago

Just so you know @leolabs this ticket is for the library firing a disconnect and extra connect incorrectly, and wasn't fixed by the mentioned issue

leolabs commented 2 years ago

Oh, thanks for the heads-up! I misread the issue as something related to your PRs.

How did you trigger the disconnect and reconnect in Ableton? Did you do it by restarting the app or by loading a new project?

I'll try to reproduce this on my side then.

leolabs commented 1 year ago

Hey @zactopus, I've just released a major update to this library and can't reproduce the issue anymore. I'll mark this as fixed for now, but feel free to reopen it if you still encounter the issue :)