search

leoliu / ggtags

Emacs frontend to GNU Global source code tagging system.
http://elpa.gnu.org
577 stars 56 forks source link

Add xref support #184

Closed nnicandro closed 5 years ago

nnicandro commented 5 years ago

Closes #160

One issue that may still need to be thought about, the ggtags XREF backend will be used both when Global can find the tag under point via ggtags-completion-table or when there is no tag under point (see ggtags--xref-backend). I decided to add this latter condition because XREF allows asking the user for a tag and if the user is intending to find a tag using the ggtags backend but point is not on a symbol, then the backend wouldn't be used if only the first condition is kept.

leoliu commented 5 years ago

BTW, since this package is placed on GNU ELPA I think they require copyright assignment for large contribution. Do you have this sorted out? Thanks. I'll go through the changes soon.

nnicandro commented 5 years ago

Just sent the request for copyright assignment.

nnicandro commented 5 years ago

OK, I was finally able to get a response from the FSF and have confirmation that they have received my signed copyright assignment. Everything is good to go on my end.

leoliu commented 5 years ago

@dzop excellent news!

leoliu commented 5 years ago

@dzop merged with thanks.

nnicandro commented 5 years ago

@leoliu thanks for making such a great package that I use every day!