leoliu / ggtags

Emacs frontend to GNU Global source code tagging system.
http://elpa.gnu.org
577 stars 56 forks source link

Incompatibility with xref: xref--marker-ring, xref--history, etc. #228

Open mandarm opened 3 months ago

mandarm commented 3 months ago

Running emacs 29.3. Line 456 of the latest xref.el (version 1.7.0) is

(make-obsolete-variable 'xref--marker-ring 'xref--history "29.1")

As a result, running ggtags-next-mark or ggtags-prev-mark throws a Symbol’s value as variable is void: xref--marker-ring error.

After adding (defvaralias 'xref--marker-ring 'xref--history) as a workaround, the test (ring-empty-p xref--marker-ring) on line 1350 of ggtags.el returns a Wrong type argument: number-or-marker-p, nil error.

At this point, I don't have much idea how to proceed. Your help would be great!