leoluk / configmaster

Enterprise-grade network device config management.
2 stars 1 forks source link

FortiGate checksum comparison masks backup failures #18

Closed leoluk closed 6 years ago

leoluk commented 7 years ago

If the checksum comparison succeeds, but the backup itself fails, the failure will no longer be visible after the next run since it will skip the backup.

This can happen if SCP is administratively disabled on the device.

We should only save the checksum if the backup succeeded:

https://github.com/leoluk/configmaster/blob/6dc29d380b06f83718e5fd290459b38051353e1a/configmaster/management/handlers/config_backup.py#L135

(Ref: T270)