search

leoluk / configmaster

Enterprise-grade network device config management.
2 stars 1 forks source link

Disallow run as a root user #49

Closed rockTA closed 5 years ago

leoluk commented 5 years ago

What's the issue you're trying to solve?

Doing this comprehensively would require a check in many other places than just the run command.

leoluk commented 5 years ago

Either way, no reason not to merge it

rockTA commented 5 years ago

As described in my other pull request (https://github.com/leoluk/configmaster/pull/47), there were some issues because admins would run this as root. It has been suggested to implement a quick fix for this specific command. In the future the user could be checked in other places too - but I don't know if it's worth the effort?

leoluk commented 5 years ago

Fine as a quick fix, but keep in mind that this will still load much of the Django framework code as root.