search

leomcelroy / svg-pcb

Design PCBs in the Browser
https://www.leomcelroy.com/svg-pcb-website
GNU General Public License v3.0
64 stars 9 forks source link

Added comments to defaultText.js and edited components names in compo… #12

Closed sennabullet closed 1 year ago

sennabullet commented 1 year ago
leomcelroy commented 1 year ago

Thanks so much for this. The tutorial is a huge contribution.

I'm a bit undecided on how to handle putting large image assets in the repo so decided to punt on that decision and move them to a CDN. I copied your tutorial to the main branch and linked it from the main README. it can be found here: https://github.com/leomcelroy/svg-pcb/blob/main/DOCS/TUTORIAL.md#svg-pcb

It's a bit confusing how the component names work. Right now they are coupled to the import location. So you found the right spot but changing that without changing the file structure will cause issues. I can decouple them and make it easier to adjust the names or add tags.

I also adopted the default text comments you suggested with some minor edits.

Because some features we're taking, some leaving, and some adjusting from the PR it was easier to manually take your commits and add them in on the main branch. In the future having smaller more focused PRs for each change would make it easier to manage which features to merge. Consequently I'm going to close this PR because most of its features have effectively been merged. Try making another small contribution so you can come up on the contributor list, you've earned it!

sennabullet commented 1 year ago

Leo Thank you for this. I will follow your suggestions.  And thank you for letting be contribute to your project.  R

Sent from Yahoo Mail on Android

On Fri, Mar 3, 2023 at 13:46, @.***> wrote:

Thanks so much for this. The tutorial is a huge contribution.

I'm a bit undecided on how to handle putting large image assets in the repo so decided to punt on that decision and move them to a CDN. I copied your tutorial to the main branch and linked it from the main README. it can be found here: https://github.com/leomcelroy/svg-pcb/blob/main/DOCS/TUTORIAL.md#svg-pcb

It's a bit confusing how the component names work. Right now they are coupled to the import location. So you found the right spot but changing that without changing the file structure will cause issues. I can decouple them and make it easier to adjust the names or add tags.

I also adopted the default text comments you suggested with some minor edits.

Because some features we're taking, some leaving, and some adjusting from the PR it was easier to manually take your commits and add them in on the main branch. In the future having smaller more focused PRs for each change would make it easier to manage which features to merge. Consequently I'm going to close this PR because most of its features have effectively been merged. Try making another small contribution so you can come up on the contributor list, you've earned it!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>