search

leomoty / SGPP

41 stars 14 forks source link

Handle popup only with left click #102

Closed Ishmaeel closed 9 years ago

Ishmaeel commented 9 years ago

Handle popup only with left click so it is possible to open giveaway pages in a new tab/window with a middle click.

nikop commented 9 years ago

Is this browser specific? Firefox works currently as expected.

Pull requests should be send to beta branch, so it can be tested. master is for current version only.

Ishmaeel commented 9 years ago

Well, it didn't occur to me to test it on Firefox. You're right of course - apparently, the event is not generated for middle clicks in Firefox, so it works as described.

So, yes. The issue is specific to Chrome, where middle click also fires that event, with a different button value (1).

Is it possible to move this PR to beta or would you like me to close and reopen?

Ishmaeel commented 9 years ago

Nevermind. I need to add support for CTRL key too anyway.