leon-ai / leon-cli

⌨️ Command-line interface (CLI) for a better use of Leon, your open-source personal assistant. GNU/Linux, macOS and Windows supported.
https://getleon.ai
MIT License
176 stars 21 forks source link

fix: removal of config/logs folders when reinstalling CLI #173

Closed theoludwig closed 2 years ago

theoludwig commented 2 years ago

What changes this PR introduce?

Instead, to store config and log folders inside the source of the CLI, we store it outside so it persists after uninstall/update of the CLI. As said in this StackOverflow thread, it is a best practice to store these kinds of files in the system path according to the OS.

To do that there is this awesome npm package: sindresorhus/conf that take care to store these files for us in the right place, sindresorhus also mention that he made this package to let command-line tools persist some data, and this exactly what we want! :smile:

List any relevant issue numbers

Fixes #171

theoludwig commented 2 years ago

🐞 [CLI 1.1.0] Reinstalling/Updating the CLI remove the config and logs folders

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: