[Bug] Usage of unsupported yum flag `--yes` during birth procedure

korve commented 2 years ago

Specs

Leon version: 1.3.0
OS (or browser) version: Fedora Linux 36 (Workstation Edition)
Node.js version: v16.16.0
Complete "leon check" (or "npm run check") output: Error: You should have at least one instance. For further information, look at the log file located at /home/andreeckardt/.config/@leon-ai/cli/log-errors.txt

Expected Behavior

When i run leon create birth, a leon instance is created on a Fedora 36 machine.

Actual Behavior

I get an error during installation:

$ leon create birth
✖ Installing packages
Error: Failed to install needed packages
For further information, look at the log file located at /home/<username>/.config/@leon-ai/cli/log-errors.txt

Within the error file, the following error is visible:

[Wed Sep 07 2022 14:05:23 GMT+0200 (Central European Summer Time)] [leon create birth] Failed to install needed packages
Error: Command failed with exit code 2: sudo --non-interactive /home/<username>/.nvm/versions/node/v16.16.0/lib/node_modules/@leon-ai/cli/scripts/dependencies/install_yum_packages.sh
usage: yum install [-c [config file]] [-q] [-v] [--version]
                   [--installroot [path]] [--nodocs] [--noplugins]
                   [--enableplugin [plugin]] [--disableplugin [plugin]]
                   [--releasever RELEASEVER] [--setopt SETOPTS]
                   [--skip-broken] [-h] [--allowerasing] [-b | --nobest] [-C]
                   [-R [minutes]] [-d [debug level]] [--debugsolver]
                   [--showduplicates] [-e ERRORLEVEL] [--obsoletes]
                   [--rpmverbosity [debug level name]] [-y] [--assumeno]
                   [--enablerepo [repo]] [--disablerepo [repo] | --repo
                   [repo]] [--enable | --disable] [-x [package]]
                   [--disableexcludes [repo]] [--repofrompath [repo,path]]
                   [--noautoremove] [--nogpgcheck] [--color COLOR] [--refresh]
                   [-4] [-6] [--destdir DESTDIR] [--downloadonly]
                   [--comment COMMENT] [--bugfix] [--enhancement]
                   [--newpackage] [--security] [--advisory ADVISORY]
                   [--bz BUGZILLA] [--cve CVES]
                   [--sec-severity {Critical,Important,Moderate,Low}]
                   [--forcearch ARCH]
                   PACKAGE [PACKAGE ...]
yum install: error: unrecognized arguments: --yes

How Do We Reproduce?

Use Fedora and try to follow the Installation chapter.

Extra (like a sample repo to reproduce the issue, etc.)

On a fedora system the --yes flag is not supported. Instead -y can be used. I don't know exactly if this is only related to fedora. Also i would expect the installer to use dnf instead of yum.

louistiti commented 2 years ago

Hi @korve, thanks for reporting. I'm moving this issue to the CLI repository.

cc @Divlo

theoludwig commented 2 years ago

Hello! @korve

Thanks for your report! Indeed it was a bug, actually --yes doesn't exist for the yum CLI, it was fixed by #196 but was not yet released. However, adding support for dnf package manager is a great suggestion. :+1: Done in this commit: https://github.com/leon-ai/leon-cli/commit/509e93ba4a21f7d4bab363ef85550f1138239c40.

In the CLI part, we already support many famous package managers for different GNU/Linux distributions, but unfortunately, on the Core side, it is not the case. Being able to run Leon on multiple CPU architectures, and distribution, it's definitely something we would like to support, and we would like to solve it before the v1.0.0 stable release (currently Leon is in beta). We will try to solve this problem later, when the core of Leon is more mature, just before the v1 stable release. You can read more here: https://github.com/leon-ai/leon/pull/302#pullrequestreview-914081908.

Meanwhile, you can use Leon without problems on Ubuntu, macOS, and Windows, also you can try Leon with a single click thanks to GitPod: https://github.com/leon-ai/leon#%EF%B8%8F-try-with-a-single-click.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

leon-ai / leon-cli