search

leon-o / iris-flw-compat

Enable Flywheel's optimizations when using shaderpacks.
MIT License
39 stars 21 forks source link

Flywheel instancing incompatible with Parallax Occlusion Mapping #97

Open gittibene opened 4 months ago

gittibene commented 4 months ago

Instanced blocks and block on contraptions don't render properly if POM is enabled. Is there any way to make this work?

LuiCat commented 2 months ago

POM requires cotangents and flywheel was not providing them. This recent change of flywheel might help.

DedMaxim commented 1 month ago

This doesn't seem to be fixed, even though the PM was merged March 6. Create contraptions are semi-transparent with just stripes of the correct texture going over them is POM is turned on. And not just Create stuff, regular tile entities like chests are also affected by this bug. Bug only appears when "Iris & Oculus Flywheel Compat" is installed.

2024-05-25_01 38 53 2024-05-25_01 39 08 2024-05-25_01 39 14 2024-05-25_01 56 41

---Environment---

Intel Xeon E5-2680v2 Nvidia GTX 1070 Samsung DDR3 ECC REG 4x8Gb Windows 10 22H2 Nvidia Driver 551.61

Minecraft 1.20.1 Forge 47.2.20 Create 0.5.1.f Embeddium 0.3.19 Iris & Oculus Flywheel Compat 0.2.5 Oculus 1.7.0

Tried with Complementary Reimagined 5.1.1, Bliss 2.0.4 and BSL 8.2.08. While Bliss creates stripes, as I described above, BSL leaves holes in some components like the water wheel and stripes on chests, and Complementary only leaves holes on some components without any stripes. PBR resource pack AVPBR R3

LuiCat commented 1 month ago

This doesn't seem to be fixed, even though the PM was merged March 6.

Well I checked the PR a moment ago and wasn't able to find anything related to tangents, too sad 😓