search

leona / helix-gpt

Code assistant language server for Helix with support for Copilot/OpenAI/Codeium/Ollama
MIT License
287 stars 19 forks source link

Publishing releases to github! #1

Closed happysalada closed 5 months ago

happysalada commented 5 months ago

Hi, first of all, thank you for making this! This is really nice!

Would you mind publishing an initial release to github ? The reason I ask is that I would like to have a go at packaging this with nix. This will likely take time, but having a first release (no matter the number) would be a first step.

ps: just in case you are interested, if you know about the litellm project https://github.com/zya/litellmjs , that could be an easy way to support other models.

leona commented 5 months ago

Hey thanks for the suggestion! I've gone ahead and set that up. I use nixos so let me know if you finish it :)

And I'll take a look at that project cheers. I'd like to support copilot and self hosted models at some point.

happysalada commented 5 months ago

Alright I'm going to have a question though. I've submitted early efforts at https://github.com/NixOS/nixpkgs/pull/283643 I've tried running the build:bin and just copying that over but that doesn't seem to work. Maybe no need to build at all and just use makebinarywrapper with bun ? since you know the package best, let me know what you think.

leona commented 5 months ago

Alright I'm going to have a question though. I've submitted early efforts at NixOS/nixpkgs#283643 I've tried running the build:bin and just copying that over but that doesn't seem to work. Maybe no need to build at all and just use makebinarywrapper with bun ? since you know the package best, let me know what you think.

I haven't packaged anything for Nix before so I can't help much sorry. What happened when you used the precompiled one though?

happysalada commented 5 months ago

no worries at all, let's just talk about how to run this. When I tried running the binary built by build:bin, it just gave me the bun help message, saying this was missing an argument. rather than running build:bin, could I not bun ./app.ts and be done with it ? (the other way would be to just fetch precompiled binaries, I'll do that if all else fails).

happysalada commented 5 months ago

alright I have an initial version running with bun run --prefer-offline --no-install ./src/app.ts

one small but potential improvement is to just throw an error if the required environment variables are not found.

leona commented 5 months ago

no worries at all, let's just talk about how to run this. When I tried running the binary built by build:bin, it just gave me the bun help message, saying this was missing an argument. rather than running build:bin, could I not bun ./app.ts and be done with it ? (the other way would be to just fetch precompiled binaries, I'll do that if all else fails).

I tried with autoPatchelf earlier and had the same problem. Strange.

alright I have an initial version running with bun run --prefer-offline --no-install ./src/app.ts

one small but potential improvement is to just throw an error if the required environment variables are not found.

Nice one. It should do that already, see here https://github.com/leona/helix-gpt/blob/b1a7bbe4f260086646a7306124c742d52d3c9660/src/config.ts#L67 A single API key is the only required config

happysalada commented 5 months ago

Nice! I'm going to wait a couple more days before updating my pull request to nixpkgs, just to make sure I don't contribute a too stale version. I think this issue can be closed now, thank you again!