search

leona / helix-gpt

Code assistant language server for Helix with support for Copilot/OpenAI/Codeium/Ollama
MIT License
285 stars 19 forks source link

Manual trigger support #40

Open cd-a opened 4 months ago

cd-a commented 4 months ago

Following up on your comment on https://github.com/leona/helix-gpt/issues/21#issuecomment-1950177400

Isn't that now implemented in helix via https://github.com/helix-editor/helix/pull/9660?

sigmaSd commented 4 months ago

Unfortunately that doesn't help a lot, the spec says that CompltionKind::Invoked is triggered even when typing an identifier, so in practice helix will always request completions, that pr just fixed the metadata sent back to the sever https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionTriggerKind

sigmaSd commented 3 months ago

What if there is was an option to disable completion completely, and add completion as a code action, I think that would solve this problem , now the user can decide when to ask for the completion

I think its a good idea what do you think @leona ?

sigmaSd commented 3 months ago

It works but its rough on the edges, too bad thought I found a solution for this problem Screencast from 2024-03-13 17-41-25.webm