search

leonardochaia / dotnet-affected-action

.NET tool for determining which projects are affected by a set of changes. Useful for large projects or monorepos.
https://github.com/leonardochaia/dotnet-affected
MIT License
15 stars 3 forks source link

Fail the action if dotnet-affected exits with exit code other than 166 #159

Closed Methuselah96 closed 1 year ago

Methuselah96 commented 1 year ago

In the status quo, if the dotnet-affected command exits with a failing status code it will be marked as successfully, whether the failing status code is expected (i.e., 166) or a true error (i.e., something other than 166).

This PR resolves the issue by calling setFailed if the exit code indicates a true failure.

leonardochaia commented 1 year ago

Hi @Methuselah96 , thanks!

I appreciate you using/testing and submitting PRs for this actions since I personally do not use it so I can't really see what is missing.

Changes look good, I'll merge.

Methuselah96 commented 1 year ago

Glad to help, you've already done the hard part in creating dotnet-affected. ❤️