leonardocustodio / polkadart

Polkadart provides developers the ability to query a node and interact with the Polkadot based chains using Dart.
https://polkadart.dev
Apache License 2.0
39 stars 16 forks source link

[Bug] Fix immortal transactions (eraPeriod = 0) #362

Closed leonardocustodio closed 1 year ago

leonardocustodio commented 1 year ago

This fix #361

codecov[bot] commented 1 year ago

Codecov Report

Merging #362 (e48ccba) into main (86309e1) will decrease coverage by 17.76%. The diff coverage is 0.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362/graphs/tree.svg?width=650&height=150&src=pr&token=HG3K4LW5UN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio)](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) ```diff @@ Coverage Diff @@ ## main #362 +/- ## =========================================== - Coverage 44.84% 27.08% -17.76% =========================================== Files 142 98 -44 Lines 8204 5800 -2404 =========================================== - Hits 3679 1571 -2108 + Misses 4525 4229 -296 ``` | [Flag](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | Coverage Δ | | |---|---|---| | [polkadart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `16.66% <0.00%> (-0.03%)` | :arrow_down: | | [polkadart_cli](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `12.27% <ø> (ø)` | | | [polkadart_keyring](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `94.25% <ø> (ø)` | | | [polkadart_scale_codec](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `54.93% <ø> (ø)` | | | [ss58](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `96.87% <ø> (ø)` | | | [substrate_bip39](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `64.34% <ø> (ø)` | | | [substrate_metadata](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | Coverage Δ | | |---|---|---| | [...ges/polkadart/lib/extrinsic/extrinsic\_payload.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvcG9sa2FkYXJ0L2xpYi9leHRyaW5zaWMvZXh0cmluc2ljX3BheWxvYWQuZGFydA==) | `0.00% <0.00%> (ø)` | | | [...kages/polkadart/lib/extrinsic/signing\_payload.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvcG9sa2FkYXJ0L2xpYi9leHRyaW5zaWMvc2lnbmluZ19wYXlsb2FkLmRhcnQ=) | `0.00% <0.00%> (ø)` | | ... and [44 files with indirect coverage changes](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/362/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio)