Wrong storage hash key for storage value

[clangenb]

In our generated code we have this:

  final _i1.StorageValue<int> _endorsementTicketsPerBootstrapper = const _i1.StorageValue<int>(
    prefix: 'EncointerCeremonies',
    storage: 'EndorsementTicketsPerBootstrapper',
    valueCodec: _i4.U8Codec.codec,
  );

The generated key hash:

    final hashedKey = _endorsementTicketsPerBootstrapper.hashedKey();

    // hashedKey: 0xa7d291a8132b2cc65c41da45f4de76796ae3d97cb4a9938c6ebddc6491b5bc06
    print("hashedKey: 0x${hex.encode(hashedKey)}");

Is wrong, the correct key hash according to polkadot-js/apps is:

So the method is wrong in this case, whereas the prefix is correct. The method has 33 characters, so my guess is that some magic happens on substrate side for prefixes > 32 bytes.

[leonardocustodio]

Ok, found the issue it is in the xxh64 algorithm actually (that is used by twox). cc @justkawal

[leonardocustodio]

Fixed on version 0.2.4

[clangenb]

I can confirm that it is fixed on our end. Thanks for the blazingly fast fix!

[clangenb]

I have to correct my statement, the hash seems to be wrong in other cases now, example:

  final _i1.StorageValue<_i3.CeremonyPhaseType> _currentPhase = const _i1.StorageValue<_i3.CeremonyPhaseType>(
    prefix: 'EncointerScheduler',
    storage: 'CurrentPhase',
    valueCodec: _i3.CeremonyPhaseType.codec,
  );

// wrong result: 
// 26dc3fa0a77526a8494180a4789f6883d9764401941df7f77a47ba7db64a6e0a
// actual value:
// 26dc3fa0a77526a8494180a4789f6883d9764401941df7f707a47ba7db64a6ea

Actual value:

It only seems to affect the last bytes.

I can confirm that the storage hash was correct before #375.

[clangenb]

It seems I can't reopen the issue unfortunately. Shall I create a new one?

[leonardocustodio]

They are pretty close though haha. I wish dart itself had those hashing algorithms. I will check it later.

[leonardocustodio]

Totally my fault this one. When converting to hex it did not use signed 2's complement. It should be fixed now, also added this string to the tests.

[leonardocustodio]

Released under version: polkadart: ^0.2.5

[clangenb]

Nice, our integration tests work again, seems to be fine, thanks a lot for this quick reaction again! 👍