search

leonardocustodio / polkadart

Polkadart provides developers the ability to query a node and interact with the Polkadot based chains using Dart.
https://polkadart.dev
Apache License 2.0
39 stars 16 forks source link

MultiSig Implementation #417

Closed justkawal closed 9 months ago

justkawal commented 10 months ago

User description

MultiSig

Type

Enhancement, Tests

Description

Changes walkthrough

Relevant files
Configuration changes
2 files
polkadart_keyring.dart
Reorganization of library structure and addition of new imports   
packages/polkadart_keyring/lib/polkadart_keyring.dart - Added import for 'dart:convert' and
'package:polkadart_scale_codec/polkadart_scale_codec.dart'. - Reorganized the structure of the library by separating source code and
utility files. - Added 'src/multisig.dart' to the part directive. - Moved 'src/extensions.dart' and 'src/constants.dart' to the 'utils'
directory.
+11/-2   
analysis_options.yaml
Addition of new linting rule                                                                         
packages/polkadart_keyring/analysis_options.yaml - Added a new rule `non_constant_identifier_names: false`.
+1/-0     
Enhancement
5 files
multisig.dart
Implementation of MultiSig class                                                                 
packages/polkadart_keyring/lib/src/multisig.dart - Added a new class `MultiSig` with methods for creating multisig bytes
and multisig addresses.
+43/-0   
constants.dart
Addition of new constant                                                                                 
packages/polkadart_keyring/lib/utils/constants.dart - Added a constant `DEV_PHRASE`.
+5/-1     
extensions.dart
Addition of KeyPairType enum                                                                         
packages/polkadart_keyring/lib/utils/extensions.dart - Added a new enum `KeyPairType` with three types: `ed25519`, `sr25519`, `
`and `
``ecdsa`.
+14/-1   
hashers.dart
Addition of new hashing function                                                                 
packages/polkadart_keyring/lib/utils/hashers.dart - Added a new function `blake2bDigest` for hashing data.
+9/-0     
utilities.dart
Addition of new utility functions                                                               
packages/polkadart_keyring/lib/utils/utilities.dart - Added several utility functions: `bnToU8a`, `_bigIntToBytes`, and `
``uint8ListCompare`.
+59/-0   
Tests
1 files
multisig_test.dart
Addition of new test cases for MultiSig                                                   
packages/polkadart_keyring/test/multisig_test.dart - Added two new test cases for validating the creation of multikey and
multikey address.
+60/-0   
Documentation
1 files
README.md
Updated README with MultiSig address creation example                       
packages/polkadart_keyring/README.md - Added a new section for creating MultiSig address.
+11/-0   
Dependencies
1 files
pubspec.yaml
Addition of new dependency                                                                             
packages/polkadart_keyring/pubspec.yaml - Added a new dependency `polkadart_scale_codec: ^1.1.2`.
+1/-0     
โœจ Usage guide:
**Overview:** The `describe` tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L46) related to the describe tool (`pr_description` section), use the following template: ``` /describe --pr_description.some_config1=... --pr_description.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_description] some_config1=... some_config2=... ```
Enabling\disabling automation
- When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the describe tool is: ``` pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...] ``` meaning the `describe` tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. - Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: ``` pr_commands = ["/describe --pr_description.use_description_markers=true", ...] ``` the tool will replace every marker of the form `pr_agent:marker_name` in the PR description with the relevant content, where `marker_name` is one of the following: - `type`: the PR type. - `summary`: the PR summary. - `walkthrough`: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the `describe` tool are quite generic: [`Bug fix`, `Tests`, `Enhancement`, `Documentation`, `Other`]. If you specify [custom labels](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md#handle-custom-labels-from-the-repos-labels-page-gem) in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: - `Main topic:performance` - pr_agent:The main topic of this PR is performance - `New endpoint` - pr_agent:A new endpoint was added in this PR - `SQL query` - pr_agent:A new SQL query was added in this PR - `Dockerfile changes` - pr_agent:The PR contains changes in the Dockerfile - ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough ๐Ÿ’Ž
For enhanced user experience, the `describe` tool can add file summaries directly to the "Files changed" tab in the PR page. This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs). To enable inline file summary, set `pr_description.inline_file_summary` in the configuration file, possible values are: - `'table'`: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab. - `true`: A collapsable file comment with changes title and a changes summary for each file in the PR. - `false` (default): File changes walkthrough will be added only to the "Conversation" tab.
Utilizing extra instructions
The `describe` tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: ``` [pr_description] extra_instructions=""" - The PR title should be in the format: ': ' - The title should be short and concise (up to 10 words) - ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** ๐Ÿ’Ž: Generate docstring for new components introduced in the PR. > - **/generate_labels** ๐Ÿ’Ž: Generate labels for the PR based on the PR's contents. > - **/analyze** ๐Ÿ’Ž: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [describe usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md) page for a comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/github-actions[bot]"><img src="https://avatars.githubusercontent.com/in/15368?v=4" />github-actions[bot]</a> commented <strong> 10 months ago</strong> </div> <div class="markdown-body"> <p><strong><a href="https://github.com/leonardocustodio/polkadart/pull/417">PR Description</a></strong> updated to latest commit (<a href="https://github.com/leonardocustodio/polkadart/commit/1757db1f8306cc9e0311192bd85bf11ee9311aeb">https://github.com/leonardocustodio/polkadart/commit/1757db1f8306cc9e0311192bd85bf11ee9311aeb</a>)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/github-actions[bot]"><img src="https://avatars.githubusercontent.com/in/15368?v=4" />github-actions[bot]</a> commented <strong> 10 months ago</strong> </div> <div class="markdown-body"> <h2>PR Analysis</h2> <ul> <li>๐ŸŽฏ <strong>Main theme:</strong> Implementation of MultiSig Address Creation</li> <li>๐Ÿ“ <strong>PR summary:</strong> This PR introduces the functionality to create MultiSig addresses in the <code>polkadart_keyring</code> package. It includes the implementation of new utility functions, a new class <code>MultiSig</code>, and new test cases. The PR also includes some reorganization of the library structure and the addition of a new dependency <code>polkadart_scale_codec: ^1.1.2</code>.</li> <li>๐Ÿ“Œ <strong>Type of PR:</strong> Enhancement</li> <li>๐Ÿงช <strong>Relevant tests added:</strong> Yes</li> <li>โฑ๏ธ <strong>Estimated effort to review [1-5]:</strong> 3, because the PR includes new functionality and several changes to the existing codebase. It also introduces a new dependency which needs to be evaluated.</li> <li>๐Ÿ”’ <strong>Security concerns:</strong> No <h2>PR Feedback</h2></li> </ul> <p><strong>๐Ÿ’ก General suggestions:</strong> The PR is well-structured and includes relevant test cases. However, it would be beneficial to include more comments in the code to explain the logic and functionality of the new methods and utility functions. This would make the code easier to understand for other developers. Also, consider handling potential exceptions that might occur during the execution of the new methods.</p> <details><summary> <strong>๐Ÿค– Code feedback:</strong></summary><hr><table><tr><td>relevant file</td><td>packages/polkadart_keyring/lib/src/multisig.dart</td></tr><tr><td>suggestion      </td><td><br> **Consider adding error handling for potential exceptions that might occur during the execution of the `createMultiSigBytes` and `createMultiSigAddress` methods. For example, you could add a try-catch block to handle any exceptions and provide a meaningful error message to the user. [important]** <br></td></tr><tr><td>relevant line</td><td><a href='https://github.com/leonardocustodio/polkadart/pull/417/files#diff-6f22452466e8a7679c95f54554c65115f50582d68868dbe8004f280ecbd068beR6'>static Uint8List createMultiSigBytes(</a></td></tr></table><hr><table><tr><td>relevant file</td><td>packages/polkadart_keyring/lib/utils/utilities.dart</td></tr><tr><td>suggestion      </td><td><br> **The function `uint8ListCompare` could be optimized by breaking the loop as soon as a difference is found between the two lists. This would avoid unnecessary iterations and improve the performance of the function. [medium]** <br></td></tr><tr><td>relevant line</td><td><a href='https://github.com/leonardocustodio/polkadart/pull/417/files#diff-e018461e3ffdc7dbdfb8fb7133d0dcdc4a909836363b3eb7d4611cf3a3b7451aR38'>int uint8ListCompare(Uint8List a, Uint8List b) {</a></td></tr></table><hr></details> <hr> <details> <summary><strong>โœจ Usage guide:</strong></summary><hr> **Overview:** The `review` tool scans the PR code changes, and generates a PR review. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on any PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L19) related to the review tool (`pr_reviewer` section), use the following template: ``` /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_reviewer] some_config1=... some_config2=... ``` <table><tr><td><details> <summary><strong> Utilizing extra instructions</strong></summary><hr> The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: ``` [pr_reviewer] # /review # extra_instructions=""" In the 'general suggestions' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> How to enable\disable automation</strong></summary><hr> - When you first install PR-Agent app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the `review` tool is: ``` pr_commands = ["/review", ...] ``` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations </details></td></tr> <tr><td><details> <summary><strong> Auto-labels</strong></summary><hr> The `review` tool can auto-generate two specific types of labels for a PR: - a `possible security issue` label, that detects possible [security issues](https://github.com/Codium-ai/pr-agent/blob/tr/user_description/pr_agent/settings/pr_reviewer_prompts.toml#L136) (`enable_review_labels_security` flag) - a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag) </details></td></tr> <tr><td><details> <summary><strong> Extra sub-tools</strong></summary><hr> The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the [possible options](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md#enabledisable-features), and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** ๐Ÿ’Ž: Generate docstring for new components introduced in the PR. > - **/generate_labels** ๐Ÿ’Ž: Generate labels for the PR based on the PR's contents. > - **/analyze** ๐Ÿ’Ž: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [review usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md) page for a comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/github-actions[bot]"><img src="https://avatars.githubusercontent.com/in/15368?v=4" />github-actions[bot]</a> commented <strong> 10 months ago</strong> </div> <div class="markdown-body"> <h2>PR Code Suggestions</h2> <table><thead><tr><th></th><th>Suggestions                                                                                                                                                          </th></tr></thead><tbody><tr><td><strong>best practice</strong></td><td><table><tr><td> <details><summary>Replace generic <code>Exception</code> with a more specific <code>ArgumentError</code>.</summary> ___ **In the `createMultiSigBytes` method, you are directly throwing an `Exception` when no <br> signatories are provided. It would be better to throw a more specific exception, like <br> `ArgumentError`, to make it clear what the problem is.** [packages/polkadart_keyring/lib/src/multisig.dart [8-10]](https://github.com/leonardocustodio/polkadart/pull/417/files#diff-6f22452466e8a7679c95f54554c65115f50582d68868dbe8004f280ecbd068beR8-R10) ```diff if (signatories.isEmpty) { - throw Exception('No signatories provided.'); + throw ArgumentError('No signatories provided.'); } ``` </details></td></tr><tr><td> <details><summary>Make <code>value</code> a required parameter in <code>bnToU8a</code> function and throw an <code>ArgumentError</code> if <code>null</code> is passed.</summary> ___ **The `bnToU8a` function currently accepts `null` as a valid input for `value`, and handles `<br> `it `<br> `by `<br> `returning `<br> `an `<br> `empty `<br> ``Uint8List`. `<br> `It `<br> `would `<br> `be `<br> `better `<br> `to `<br> `make `<br> ``value` <br> a required parameter and throw an `ArgumentError` if `null` is passed.** [packages/polkadart_keyring/lib/utils/utilities.dart [4-8]](https://github.com/leonardocustodio/polkadart/pull/417/files#diff-e018461e3ffdc7dbdfb8fb7133d0dcdc4a909836363b3eb7d4611cf3a3b7451aR4-R8) ```diff -Uint8List bnToU8a(int? value, +Uint8List bnToU8a(int value, {int bitLength = -1, bool isLittleEndian = true, bool isNegative = false}) { if (value == null) { - return bitLength == -1 ? Uint8List(1) : Uint8List((bitLength + 7) >> 3); + throw ArgumentError('value cannot be null'); } ``` </details></td></tr><tr><td> <details><summary>Avoid modifying input lists in-place by creating and sorting a copy instead. </summary> ___ **The `createMultiSigBytes` method currently sorts the `signatories` list in-place. This <br> modifies the input list, which can lead to unexpected side effects. Consider creating a <br> copy of the list and sorting that instead.** [packages/polkadart_keyring/lib/src/multisig.dart [13]](https://github.com/leonardocustodio/polkadart/pull/417/files#diff-6f22452466e8a7679c95f54554c65115f50582d68868dbe8004f280ecbd068beR13-R13) ```diff -signatories.sort(uint8ListCompare); +final sortedSignatories = List<Uint8List>.from(signatories)..sort(uint8ListCompare); ``` </details></td></tr></table></td></tr><tr><td><strong>enhancement</strong></td><td><table><tr><td> <details><summary>Simplify the <code>uint8ListCompare</code> function by using <code>Iterable.zip</code> and a for-each loop.</summary> ___ **The `uint8ListCompare` function currently uses a while loop to iterate over the elements <br> of the lists. This could be simplified by using the `Iterable.zip` method to create pairs <br> of corresponding elements, and then using a for-each loop to iterate over these pairs.** [packages/polkadart_keyring/lib/utils/utilities.dart [39-58]](https://github.com/leonardocustodio/polkadart/pull/417/files#diff-e018461e3ffdc7dbdfb8fb7133d0dcdc4a909836363b3eb7d4611cf3a3b7451aR39-R58) ```diff -int i = 0; -while (true) { - final overA = i >= a.length; - final overB = i >= b.length; - if (overA && overB) { - // both ends reached - return 0; - } else if (overA) { - // a has no more data, b has data - return -1; - } else if (overB) { - // b has no more data, a has data - return 1; - } else if (a[i] != b[i]) { - // the number in this index doesn't match - // (we don't use u8aa[i] - u8ab[i] since that doesn't match with localeCompare) - return a[i] > b[i] ? 1 : -1; +for (final pair in a.zip(b)) { + if (pair.first != pair.second) { + return pair.first > pair.second ? 1 : -1; } - i++; } +if (a.length != b.length) { + return a.length > b.length ? 1 : -1; +} +return 0; ``` </details></td></tr></table></td></tr></tr></tbody></table><hr> <details> <summary><strong>โœจ Usage guide:</strong></summary><hr> **Overview:** The `improve` tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L69) related to the improve tool (`pr_code_suggestions` section), use the following template: ``` /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_code_suggestions] some_config1=... some_config2=... ``` <table><tr><td><details> <summary><strong> Enabling\disabling automation </strong></summary><hr> When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the improve tool is: ``` pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...] ``` meaning the `improve` tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically. </details></td></tr> <tr><td><details> <summary><strong> Utilizing extra instructions</strong></summary><hr> Extra instructions are very important for the `improve` tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: ``` [pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> A note on code suggestions quality</strong></summary><hr> - While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. - Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. - Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the [custom suggestions :gem:](https://github.com/Codium-ai/pr-agent/blob/main/docs/CUSTOM_SUGGESTIONS.md) tool - With large PRs, best quality will be obtained by using 'improve --extended' mode. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** ๐Ÿ’Ž: Generate docstring for new components introduced in the PR. > - **/generate_labels** ๐Ÿ’Ž: Generate labels for the PR based on the PR's contents. > - **/analyze** ๐Ÿ’Ž: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [improve usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/IMPROVE.md) page for a more comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codecov[bot]"><img src="https://avatars.githubusercontent.com/in/254?v=4" />codecov[bot]</a> commented <strong> 10 months ago</strong> </div> <div class="markdown-body"> <h2><a href="https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio">Codecov</a> Report</h2> <p>Attention: <code>121 lines</code> in your changes are missing coverage. Please review.</p> <blockquote> <p>Comparison is base <a href="https://app.codecov.io/gh/leonardocustodio/polkadart/commit/b59e22a01583536194cd0fba9bc6740ce964f235?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio">(<code>b59e22a</code>)</a> 48.84% compared to head <a href="https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio">(<code>daee509</code>)</a> 48.66%. Report is 2 commits behind head on main.</p> </blockquote> <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/graphs/tree.svg?width=650&height=150&src=pr&token=HG3K4LW5UN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio)](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) ```diff @@ Coverage Diff @@ ## main #417 +/- ## ========================================== - Coverage 48.84% 48.66% -0.18% ========================================== Files 177 181 +4 Lines 9445 9527 +82 ========================================== + Hits 4613 4636 +23 - Misses 4832 4891 +59 ``` | [Flag](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | Coverage ฮ” | | |---|---|---| | [polkadart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `16.41% <0.00%> (-0.42%)` | :arrow_down: | | [polkadart_cli](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `12.04% <รธ> (รธ)` | | | [polkadart_keyring](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `65.12% <0.00%> (-6.65%)` | :arrow_down: | | [polkadart_scale_codec](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `55.02% <88.88%> (+0.09%)` | :arrow_up: | | [secp256k1_ecdsa](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `90.00% <รธ> (รธ)` | | | [sr25519](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `85.91% <รธ> (รธ)` | | | [ss58](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `96.87% <รธ> (รธ)` | | | [substrate_bip39](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `56.37% <รธ> (รธ)` | | | [substrate_metadata](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | `87.74% <100.00%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | Coverage ฮ” | | |---|---|---| | [packages/polkadart\_keyring/lib/src/sr25519.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvcG9sa2FkYXJ0X2tleXJpbmcvbGliL3NyYy9zcjI1NTE5LmRhcnQ=) | `55.88% <รธ> (+0.80%)` | :arrow_up: | | [...ges/polkadart\_scale\_codec/lib/primitives/enum.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvcG9sa2FkYXJ0X3NjYWxlX2NvZGVjL2xpYi9wcmltaXRpdmVzL2VudW0uZGFydA==) | `70.96% <100.00%> (+2.54%)` | :arrow_up: | | [...ges/substrate\_metadata/lib/parsers/v14\_parser.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvc3Vic3RyYXRlX21ldGFkYXRhL2xpYi9wYXJzZXJzL3YxNF9wYXJzZXIuZGFydA==) | `99.29% <100.00%> (+0.05%)` | :arrow_up: | | [...es/substrate\_metadata/lib/types/era\_extrinsic.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvc3Vic3RyYXRlX21ldGFkYXRhL2xpYi90eXBlcy9lcmFfZXh0cmluc2ljLmRhcnQ=) | `97.61% <100.00%> (+3.17%)` | :arrow_up: | | [...kages/substrate\_metadata/lib/types/extrinsics.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvc3Vic3RyYXRlX21ldGFkYXRhL2xpYi90eXBlcy9leHRyaW5zaWNzLmRhcnQ=) | `94.28% <100.00%> (+0.16%)` | :arrow_up: | | [packages/polkadart/lib/provider.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvcG9sa2FkYXJ0L2xpYi9wcm92aWRlci5kYXJ0) | `1.92% <0.00%> (รธ)` | | | [packages/polkadart/lib/substrate/era.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvcG9sa2FkYXJ0L2xpYi9zdWJzdHJhdGUvZXJhLmRhcnQ=) | `2.56% <0.00%> (รธ)` | | | [...art/lib/extrinsic/signed\_extensions/asset\_hub.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvcG9sa2FkYXJ0L2xpYi9leHRyaW5zaWMvc2lnbmVkX2V4dGVuc2lvbnMvYXNzZXRfaHViLmRhcnQ=) | `0.00% <0.00%> (รธ)` | | | [...art/lib/extrinsic/signed\_extensions/substrate.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvcG9sa2FkYXJ0L2xpYi9leHRyaW5zaWMvc2lnbmVkX2V4dGVuc2lvbnMvc3Vic3RyYXRlLmRhcnQ=) | `0.00% <0.00%> (รธ)` | | | [...kages/polkadart\_scale\_codec/lib/core/registry.dart](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio#diff-cGFja2FnZXMvcG9sa2FkYXJ0X3NjYWxlX2NvZGVjL2xpYi9jb3JlL3JlZ2lzdHJ5LmRhcnQ=) | `67.10% <0.00%> (-0.44%)` | :arrow_down: | | ... and [7 more](https://app.codecov.io/gh/leonardocustodio/polkadart/pull/417?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Leonardo+Custodio) | | </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/justkawal"><img src="https://avatars.githubusercontent.com/u/49296873?v=4" />justkawal</a> commented <strong> 10 months ago</strong> </div> <div class="markdown-body"> <p>Looking into it.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/justkawal"><img src="https://avatars.githubusercontent.com/u/49296873?v=4" />justkawal</a> commented <strong> 9 months ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Also, it is important to note that the scope of this ticket isn't only multisig account creation. We also need to be able to send the call, decode the call, make the deposit, cancel the call.</p> <p>You can find more information in the following links: <a href="https://wiki.polkadot.network/docs/learn-guides-accounts-multisig">https://wiki.polkadot.network/docs/learn-guides-accounts-multisig</a> <a href="https://support.polkadot.network/support/solutions/articles/65000181826-how-to-create-and-use-a-multisig-account">https://support.polkadot.network/support/solutions/articles/65000181826-how-to-create-and-use-a-multisig-account</a></p> </blockquote> <p>I researched the internet, but wasn't able to find a code sample or example to mimic/implement the multisig (<code>initiate</code>, <code>approveAsMulti</code>, <code>asMulti</code>, and <code>cancel</code>).</p> <p>Whenever you find time, let me know. @leonardocustodio </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/leonardocustodio"><img src="https://avatars.githubusercontent.com/u/5619696?v=4" />leonardocustodio</a> commented <strong> 9 months ago</strong> </div> <div class="markdown-body"> <p>You can find the methods here: <a href="https://github.com/paritytech/txwrapper-core/tree/main/packages/txwrapper-substrate/src/methods/multisig">https://github.com/paritytech/txwrapper-core/tree/main/packages/txwrapper-substrate/src/methods/multisig</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/justkawal"><img src="https://avatars.githubusercontent.com/u/49296873?v=4" />justkawal</a> commented <strong> 9 months ago</strong> </div> <div class="markdown-body"> <p>@leonardocustodio I guess the PR looks good now....</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/leonardocustodio"><img src="https://avatars.githubusercontent.com/u/5619696?v=4" />leonardocustodio</a> commented <strong> 9 months ago</strong> </div> <div class="markdown-body"> <p>Is this also for #359 or only multisig?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/justkawal"><img src="https://avatars.githubusercontent.com/u/49296873?v=4" />justkawal</a> commented <strong> 9 months ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Is this also for #359 or only multisig?</p> </blockquote> <p>Umm.... Yes, I have added functionality to get and parse every <code>signedExtensions</code> from the <code>chain metadata</code> even the <code>custom</code> as well and provide access to that from <code>TypeRegistry</code>....</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>ยฉ <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>