search

leonardoquevedox / capacitor-resources

Generates icon & splash screen for Capacitor projects using javascript only.
MIT License
136 stars 16 forks source link

Bug Fix - Copy Android/iOS - Error: ENOENT: no such file or directory #12

Closed bvdalling closed 8 months ago

bvdalling commented 2 years ago

Description

This PR aims to fix the error referenced in https://github.com/leonardoquevedox/capacitor-resources/issues/7. This fixes the error by wrapping the paths in a string. This allows Node to parse the correct file path to the copy modules. Please reference this Stack Overflow accepted answer as a form of proof. Expected Impact

Impact

This fix should have no impact on existing users and installations. This addresses how Node parsed the file path for an expected resource. This only affects the exec statements in src/copy/index.js by wrapping the file path inside of a string. Tests

Testing

This has been tested in a file path on windows c:\Users\first last\Projects\ionic-app and c:\Users\firstlast\Projects\ionic-app. This has also been tested with the same parameters on Mac OS Monterey with success.

leonardoquevedox commented 8 months ago

Hi, @bvdalling! Thank you so much for you effort on solving this issue: These are the principles capacitor-resources was built on: The community thinks better than the individual. Long live open source!