Closed leonardowf closed 1 year ago
Total Coverage: 89.31
> baroneza@1.0.0 coverage > jest --coverage -------------------------------------|---------|----------|---------|---------|------------------------- File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s -------------------------------------|---------|----------|---------|---------|------------------------- All files | 88.92 | 76.42 | 80.09 | 89.31 | endpoints | 59.46 | 100 | 50 | 59.46 | create-release-endpoint.ts | 100 | 100 | 100 | 100 | release-version-endpoint.ts | 0 | 100 | 0 | 0 | 2-45 start-train-endpoint.ts | 100 | 100 | 100 | 100 | tag-endpoint.ts | 100 | 100 | 100 | 100 | update-release-endpoint.ts | 0 | 100 | 0 | 0 | 2-32 use-cases | 95.02 | 76.19 | 92.8 | 95 | ask-confirmation-use-case.ts | 100 | 100 | 100 | 100 | create-branch-use-case.ts | 63.64 | 100 | 25 | 63.64 | 31-42 create-changelog-use-case.ts | 96.08 | 80 | 100 | 96.08 | 225,245 create-milestone-use-case.ts | 94.74 | 50 | 100 | 94.74 | 57 create-release-use-case.ts | 97.3 | 66.67 | 87.5 | 97.3 | 139 create-version-use-case.ts | 100 | 100 | 100 | 100 | extract-tickets-use-case.ts | 100 | 100 | 100 | 100 | merge-back-use-case.ts | 100 | 100 | 100 | 100 | read-pull-request-info-use-case.ts | 100 | 100 | 100 | 100 | release-version-use-case.ts | 100 | 100 | 100 | 100 | start-train-use-case.ts | 100 | 100 | 100 | 100 | tag-use-case.ts | 96 | 100 | 90.91 | 96 | 107 update-release-use-case.ts | 85.42 | 50 | 84.62 | 85.42 | 163-171,185,205,261,288 workers | 77.91 | 91.3 | 56.25 | 80 | branch-creator.ts | 100 | 100 | 100 | 100 | commit-extractor.ts | 58.33 | 100 | 33.33 | 58.33 | 40-59 github-draft-release-guesser.ts | 100 | 100 | 100 | 100 | jira-tagger.ts | 27.27 | 100 | 7.69 | 35.29 | 28-65 jira-ticket-parser.ts | 100 | 91.67 | 100 | 100 | 18 keep-changelog-parser.ts | 100 | 100 | 100 | 100 | message-sender.ts | 50 | 0 | 20 | 50 | 30-60 milestone-creator.ts | 100 | 100 | 100 | 100 | pr-number-extractor.ts | 100 | 100 | 100 | 100 | pull-request-creator.ts | 60 | 100 | 25 | 60 | 29-47 pull-request-description-writer.ts | 0 | 100 | 0 | 0 | 8-22 reactions-reader.ts | 72.73 | 50 | 40 | 72.73 | 36-47 release-page-creator.ts | 100 | 100 | 100 | 100 | sha-finder.ts | 100 | 100 | 100 | 100 | workers/keep-changelog-builder | 99.02 | 57.14 | 100 | 98.84 | commits-pr-number-parser.ts | 100 | 100 | 100 | 100 | keep-changelog-builder.ts | 100 | 0 | 100 | 100 | 27 markdown-keep-changelog-builder.ts | 100 | 62.5 | 100 | 100 | 32-62 slack-keep-changelog-builder.ts | 97.83 | 50 | 100 | 97.22 | 36 -------------------------------------|---------|----------|---------|---------|-------------------------
Total Coverage: 91.06
> baroneza@1.0.0 coverage > jest --coverage -------------------------------------|---------|----------|---------|---------|------------------------- File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s -------------------------------------|---------|----------|---------|---------|------------------------- All files | 90.61 | 76.42 | 83.04 | 91.06 | endpoints | 89.19 | 100 | 88.89 | 89.19 | create-release-endpoint.ts | 100 | 100 | 100 | 100 | release-version-endpoint.ts | 100 | 100 | 100 | 100 | start-train-endpoint.ts | 100 | 100 | 100 | 100 | tag-endpoint.ts | 100 | 100 | 100 | 100 | update-release-endpoint.ts | 0 | 100 | 0 | 0 | 2-32 use-cases | 94.95 | 76.19 | 92.74 | 94.94 | ask-confirmation-use-case.ts | 100 | 100 | 100 | 100 | create-branch-use-case.ts | 63.64 | 100 | 25 | 63.64 | 31-42 create-changelog-use-case.ts | 96.08 | 80 | 100 | 96.08 | 225,245 create-milestone-use-case.ts | 94.74 | 50 | 100 | 94.74 | 57 create-release-use-case.ts | 97.3 | 66.67 | 87.5 | 97.3 | 139 create-version-use-case.ts | 100 | 100 | 100 | 100 | extract-tickets-use-case.ts | 100 | 100 | 100 | 100 | merge-back-use-case.ts | 100 | 100 | 100 | 100 | read-pull-request-info-use-case.ts | 100 | 100 | 100 | 100 | release-version-use-case.ts | 100 | 100 | 100 | 100 | start-train-use-case.ts | 100 | 100 | 100 | 100 | tag-use-case.ts | 96 | 100 | 90.91 | 96 | 107 update-release-use-case.ts | 85.42 | 50 | 84.62 | 85.42 | 163-171,185,205,261,288 workers | 77.91 | 91.3 | 56.25 | 80 | branch-creator.ts | 100 | 100 | 100 | 100 | commit-extractor.ts | 58.33 | 100 | 33.33 | 58.33 | 40-59 github-draft-release-guesser.ts | 100 | 100 | 100 | 100 | jira-tagger.ts | 27.27 | 100 | 7.69 | 35.29 | 28-65 jira-ticket-parser.ts | 100 | 91.67 | 100 | 100 | 18 keep-changelog-parser.ts | 100 | 100 | 100 | 100 | message-sender.ts | 50 | 0 | 20 | 50 | 30-60 milestone-creator.ts | 100 | 100 | 100 | 100 | pr-number-extractor.ts | 100 | 100 | 100 | 100 | pull-request-creator.ts | 60 | 100 | 25 | 60 | 29-47 pull-request-description-writer.ts | 0 | 100 | 0 | 0 | 8-22 reactions-reader.ts | 72.73 | 50 | 40 | 72.73 | 36-47 release-page-creator.ts | 100 | 100 | 100 | 100 | sha-finder.ts | 100 | 100 | 100 | 100 | workers/keep-changelog-builder | 99.02 | 57.14 | 100 | 98.84 | commits-pr-number-parser.ts | 100 | 100 | 100 | 100 | keep-changelog-builder.ts | 100 | 0 | 100 | 100 | 27 markdown-keep-changelog-builder.ts | 100 | 62.5 | 100 | 100 | 32-62 slack-keep-changelog-builder.ts | 97.83 | 50 | 100 | 97.22 | 36 -------------------------------------|---------|----------|---------|---------|-------------------------
When releasing in multiple projects, if one request failed (for example, release not found) then baroneza would not call release on the other project keys by design.
With this PR, we ignore errors and continue releasing for all project keys.
Reference: https://www.learnrxjs.io/learn-rxjs/operators/combination/forkjoin