leonardt / fault

A Python package for testing hardware (part of the magma ecosystem)
BSD 3-Clause "New" or "Revised" License
41 stars 13 forks source link

set pipefail when running verilator command #100

Closed leonardt closed 5 years ago

leonardt commented 5 years ago

Fixes sub issue in https://github.com/StanfordAHA/lassen/issues/66 where the verilator command was failing silently

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 916


Changes Missing Coverage Covered Lines Changed/Added Lines %
fault/system_verilog_target.py 0 5 0.0%
<!-- Total: 0 5 0.0% -->
Files with Coverage Reduction New Missed Lines %
fault/system_verilog_target.py 1 16.38%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 910: -0.09%
Covered Lines: 1365
Relevant Lines: 1786

💛 - Coveralls
leonardt commented 5 years ago

Changed base to sv-file-io so i could use iverilog

Kuree commented 5 years ago

@leonardt Is it okay to merge now?

leonardt commented 5 years ago

@Kuree almost, working through a vcs issue