search

leonardt / fault

A Python package for testing hardware (part of the magma ecosystem)
BSD 3-Clause "New" or "Revised" License
41 stars 13 forks source link

Remove shell=True, fix test to skip if irun not available #142

Closed leonardt closed 5 years ago

leonardt commented 5 years ago

The issue was that the test was not being skipped if irun was not available, but turns out the error code wasn't propagating with shell=True which is strange

leonardt commented 5 years ago

Ah, I see, the test expects an AssertionError because it's designed to fail. However, when changing from shell=True, we actually get

FileNotFoundError: [Errno 2] No such file or directory: 'irun': 'irun'

so that wasn't being caught by the except statement.

sgherbst commented 5 years ago

Looks great, thanks!