search

leonardt / fault

A Python package for testing hardware (part of the magma ecosystem)
BSD 3-Clause "New" or "Revised" License
41 stars 13 forks source link

Fix deadlock in subprocess logic #237

Closed leonardt closed 4 years ago

leonardt commented 4 years ago

See https://stackoverflow.com/questions/1445627/how-can-i-find-out-why-subprocess-popen-wait-waits-forever-if-stdout-pipe for some more details

Kuree commented 4 years ago

@leonardt Do you want me to try out Github actions instead of Travis? Github actions uses latest OSX.

leonardt commented 4 years ago

@Kuree sure, but I'm not exactly sure if this issue is fixed with the latest OS X, looking into it now, I think perhaps the verilator version on homebrew got updated and now it's not working with the travis environment

Kuree commented 4 years ago

My guess is that the apple clang came with the OSX image is too old. Switching to newest image should help.

Kuree commented 4 years ago

@leonardt See https://github.com/leonardt/fault/pull/238, which fixes the macos issue via Github Actions.