search

leonardt / hwtypes

Python implementations of fixed size hardware types (Bit, BitVector, UInt, SInt, ...) based on the SMT-LIB2 semantics
BSD 3-Clause "New" or "Revised" License
18 stars 4 forks source link

Add AnonymousProduct type #123

Closed cdonovick closed 4 years ago

cdonovick commented 4 years ago

@leonardt if there are more hooks that would be useful for magma we should add them.

leonardt commented 4 years ago

I'll have to review the code, but there certainly might be some more. Also similar ones for Bits would be good too. I'll get back to you

leonardt commented 4 years ago

Testing this locally it doesn't seem to break magma, so I would say it's safe to merge when ready and we can update magma to use these callbacks as a separate step.

cdonovick commented 4 years ago

Sounds good. I didn't think it should break magma as the interfaces you overload were unaffected. Rerunning garnet flow when it passes I will merge.

Kuree commented 4 years ago

Unfortunately buildkite links the build with particular commit on the GarnetFlow. Since this PR is filed during the flow outage, rerunning the flow won't work. You can amend your last commit and force push to this PR to trigger a new build.

rsetaluri commented 4 years ago

I've been preferring git commit --allow-empty -m "Trigger CI" and a normal (non-force) push