search

leonardt / pycoreir

Python bindings for coreir
BSD 3-Clause "New" or "Revised" License
10 stars 6 forks source link

Remove Python version tag for Linux wheels #132

Closed Kuree closed 4 years ago

Kuree commented 4 years ago

Linux Python3.7 only is getting a little bit annoying as Ubuntu 20.04 LTS ships Python3.8 instead. Since CoreIR doesn't build against Python ABI, we can safely remove the Python version tag in the wheel. This PR allows universal Python3 wheel on linux.

Kuree commented 4 years ago

Yes. this is a limitation of the aha flow app I wrote. I think I will spend some time in the near future to upgrade the app so that it will send repo address as well in addition to the SHA1 hash.

hofstee commented 4 years ago

Yeah, I have an issue open for this limitation on the aha repo. I can't do anything about it until the app mentioned is updated because I just dont get the information needed at runtime.

leonardt commented 4 years ago

Looks like the linux wheel just says py3 now (https://pypi.org/project/coreir/2.0.72/#files), @Kuree can you test it out to see if it resolves your issue with 3.8?

Kuree commented 4 years ago

@leonardt Yes it works now.

Kuree commented 4 years ago

@leonardt Also can you test the same script on Mac? I think it should work, but don't have access to mac.