search

leonardt / pycoreir

Python bindings for coreir
BSD 3-Clause "New" or "Revised" License
10 stars 6 forks source link

Link #148

Closed rdaly525 closed 3 years ago

rdaly525 commented 3 years ago

Adds APIs for coreir linking/loading. Depends on https://github.com/rdaly525/coreir/pull/998

Should fix broken master.

leonardt commented 3 years ago

Looks like the latest release isn't working with magma https://travis-ci.org/github/phanrahan/magma/builds/766012960, have you tried this with the magma test suite? Maybe there's something we haven't covered in the test here.

rdaly525 commented 3 years ago

@rsetaluri and I are debugging now. There were a couple of issues related to a new linking check (cannot link a definition to an existing module with a definition). Worst case is I can downgrade that check to a warning.

rdaly525 commented 3 years ago

Basically this issue shows up if you save a file then immediately load the file again in the same context

rsetaluri commented 3 years ago

@rdaly525 @leonardt I think https://github.com/phanrahan/magma/pull/944/commits/4868acd6da0490ff405c5a53d5361af61d84c419 which is a part of https://github.com/phanrahan/magma/pull/944/ should fix. should be merged soon

leonardt commented 3 years ago

Seems like mantle is also failing now: https://travis-ci.org/github/phanrahan/mantle/builds/766019464, not sure if it's necessarily related but with the timing it may be. It seems to be in the simulator though, not sure if there's any changes that would affect that?

leonardt commented 3 years ago

Upgrading the pycoreir version also breaks this test in fault:

~/repos/fault eq-and*
base ❯ pytest tests/test_tester/test_symbolic_tester.py::test_tester_magma_internal_signals_verilator

see also https://github.com/leonardt/fault/pull/305/checks?check_run_id=2291668273

rdaly525 commented 3 years ago

Seems like mantle is also failing now: https://travis-ci.org/github/phanrahan/mantle/builds/766019464, not sure if it's necessarily related but with the timing it may be. It seems to be in the simulator though, not sure if there's any changes that would affect that?

@rsetaluri is this fixed with your simulator changes to magma?

rdaly525 commented 3 years ago

Upgrading the pycoreir version also breaks this test in fault:

~/repos/fault eq-and*
base ❯ pytest tests/test_tester/test_symbolic_tester.py::test_tester_magma_internal_signals_verilator

see also https://github.com/leonardt/fault/pull/305/checks?check_run_id=2291668273

Ill investigate

rsetaluri commented 3 years ago

@rdaly525 simulator changes were merged into magma; perhaps not released

rdaly525 commented 3 years ago

That fault test is working for me locally with coreir/pycoreir master.

rsetaluri commented 3 years ago

i think @leonardt did a merge recently though