search

leonbreedt / FavIcon

Swift library to detect icons supported by a website.
Other
126 stars 37 forks source link

How to use and import in SWIFT4? #12

Closed gaborcsontos closed 6 years ago

gaborcsontos commented 6 years ago

I tried to add into my project, but to be honest, I ended up with a bunch of errors, and also it doesn't find these files.

import "libxml/tree.h"

import "libxml/xpath.h"

import "libxml/xpathInternals.h"

leonbreedt commented 6 years ago

Hi! Thanks for the report.

Yes, this library needs some Swift 4 love!

Hopefully I will get some time to look at the forks and see if someone has done something useful.

Cheers!

vitovalov commented 6 years ago

Spent 2h+ trying to make it work with swift 4 but due to my lack of exp. in iOS, I couldn't. Please, make it to CocoaPods.

Thanks @leonbreedt !

leonbreedt commented 6 years ago

Just an update @csontosgabor and @vitovalov - Busy rewriting the library for Swift 4.

Will make it a CocoaPod as well, which should fix the libxml path issues for you.

gaborcsontos commented 6 years ago

@leonbreedt Thanks mate. Hope it will be ready soon. By the way incredible job so far as well.!:) Peace, love from London.

leonbreedt commented 6 years ago

@gabormajorszki @vitovalov I've released the rewritten Swift 4.0 version of this library, it's now on CocoaPods.org as well, see the README for the snippet you need to put in your Podfile.

Released version is 3.0.1.

gaborcsontos commented 6 years ago

Cheers mate!!! ::) God bless you!