leondz / garak

LLM vulnerability scanner
https://discord.gg/uVch4puUCs
Apache License 2.0
1.03k stars 121 forks source link

remove extraneous default params for nims that expect conservative pa… #749

Closed leondz closed 3 days ago

leondz commented 1 week ago

resolves #748

one question - why are these defaults defined twice?

    # template defaults optionally override when extending
    DEFAULT_PARAMS = Generator.DEFAULT_PARAMS | {
        "temperature": 0.7,
        "top_p": 1.0,
        "frequency_penalty": 0.0,
        "presence_penalty": 0.0,
        "stop": ["#", ";"],
        "blocked_params": set(),
    }

    temperature = 0.7
    top_p = 1.0
    frequency_penalty = 0.0
    presence_penalty = 0.0
    stop = ["#", ";"]
    blocked_params = set()
leondz commented 1 week ago

-- ideally would have liked to have done this via config, not sure it woulda been possible though