leonelquinteros / gotext

Go (Golang) GNU gettext utilities package
Other
432 stars 58 forks source link

go embed fs with path #98

Open llonchj opened 4 months ago

llonchj commented 4 months ago

Before creating your Pull Request...

Go embed FS are

Is this a fix, improvement or something else?

yes,

What does this change implement/fix?

Bumping go version can be troublesome for existing users, although embed.FS tests will not be supported. It is possible to keep 1.13 compatibility by removing the additional unit test case.

Either way, in order to use embed.FS path seems to be required.

I have ...

llonchj commented 4 months ago

@leonelquinteros what is the best case scenario for this PR?

  1. bump go version to 1.16, or
  2. remove the unittest for go:embed.