search

leonerd / tree-sitter-perl-LEGACY

a perl parser for javascript
MIT License
4 stars 0 forks source link

Issue 10 - Semicolon nodes #14

Closed rabbiveesh closed 2 years ago

rabbiveesh commented 2 years ago

will close #10

Pretty straightforward change

leonerd commented 2 years ago

This will need some rebase/fixup because master has moved on.

The tests all look better now.

I'm unconvinced this is the right longterm solution for the actual grammar though, but we can tidy that up in another change that won't break the tests. For now lets tidy this one up as-is and merge it.

rabbiveesh commented 2 years ago

Could you open a new issue about your long term thoughts on this topic? I'd like to keep record

On Tue, Mar 1, 2022, 22:46 Paul Evans @.***> wrote:

This will need some rebase/fixup because master has moved on.

The tests all look better now.

I'm unconvinced this is the right longterm solution for the actual grammar though, but we can tidy that up in another change that won't break the tests. For now lets tidy this one up as-is and merge it.

— Reply to this email directly, view it on GitHub https://github.com/leonerd/tree-sitter-perl/pull/14#issuecomment-1055843106, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFURPKTNHPAN6TQOCUBGDU3U5Z623ANCNFSM5PVCCKPA . You are receiving this because you authored the thread.Message ID: @.***>