search

leongdl135 / pe

0 stars 0 forks source link

Adding of old tasks are allowed. #7

Open leongdl135 opened 1 year ago

leongdl135 commented 1 year ago

Steps to reproduce:

  1. type addtask Technical Interview /at 04-11-2022 17:00

Expected: Task should not be added since it already occurred in the past. Or at least a warning message that the tasks is old.

Outcome: Task has been added.

nus-pe-bot commented 1 year ago

Team's Response

This is the intended behaviour, since there is a possibility that the user has already completed the task he or she is adding but still wants to store it for reference. Even if an old task is added, the one being displayed is still an upcoming task, if any. Additionally, it would not hinder the user, since on the left panel what would be displayed is the upcoming task. Old tasks will not be displayed as upcoming tasks.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that a warning should be issued in this case since the application tracks important details regarding an internship. Imagine if the user makes use of the application to keep track of an important upcoming OA for an internship. However, he has input mistakenly keyed in the wrong date that occurred in the past.

As your team has mentioned,

"since on the left panel what would be displayed is the upcoming task. Old tasks will not be displayed as upcoming tasks. "

The user will have no idea that he has this upcoming assessment unless he uses the select command to take a closer look at the upcoming assessments. Without a clear warning in the User Guide or feedback in the result box, this could lead to a very bad outcome for the user where he misses a OA and as such lose a job opportunity.

Additionally, these is no distinction between past tasks and upcoming tasks in the tasks list, where all the tasks are just displayed together in one block as shown below.

image.png

As such, I do not really see the value in adding old tasks, since they are not displayed in a separate section, but rather just clumped together with the upcoming tasks which might confuse the user as well. If your intended outcome was for the user to store completed tasks, it would be simple to implement another list of completed tasks which will allow the user to have a better experience.