leongersen / noUiSlider

noUiSlider is a lightweight, ARIA-accessible JavaScript range slider with multi-touch and keyboard support. It is fully GPU animated: no reflows, so it is fast; even on older devices. It also fits wonderfully in responsive designs and has no dependencies.
https://refreshless.com/nouislider/
MIT License
5.66k stars 659 forks source link

Feature/keyboard multiplier #1151

Closed dsasko closed 3 years ago

dsasko commented 3 years ago

First of all, thanks for writing such a useful plugin.

This PR came out of the need to differentiate regular steps from keyboard steps, but is a bit more than that. This is particularly useful when dealing with the combination of small step sizes and big ranges.

Whats included:

This PR also resolves:

Please let me know if you would consider merging the changes and if you want me to make additional modifications.

leongersen commented 3 years ago

Hi @dsasko, thanks for your contribution. This looks good, and I like this feature and the documentation.

I'm not so keen on merging the Docker part of the PR; I don't use Docker myself and I'd rather not maintain/support it here. If you'd remove those changes, I'll get this tested and merged.

dsasko commented 3 years ago

@leongersen The dockerisation was only a means to an end because I don't have php installed on my machine and I wanted to test the solution. I figured you and other future contributors could benefit from it as it would enable more people to contribute and also streamline the process a bit more.

That being said, I have removed dockerisation from the PR.

If you decide, at some point, to bring it back just let me know if you want me to create a new PR for it.

dsasko commented 3 years ago

@leongersen Please note this is not a breaking change as the default setting of the keyboardModifier is set to 1. This will result in exactly the same behavior if the option is not defined.

leongersen commented 3 years ago

Quick update: I meant to merge this today, but Github is having issues. I'll try again later.

leongersen commented 3 years ago

I've just merged this and released noUiSlider 15.3.0. Thank you, @dsasko!

I'll have a look at better documenting running the documentation locally as well (and potentially bringing in the option to run it in Docker), thanks for your feedback in that area.