search

leongersen / noUiSlider

noUiSlider is a lightweight, ARIA-accessible JavaScript range slider with multi-touch and keyboard support. It is fully GPU animated: no reflows, so it is fast; even on older devices. It also fits wonderfully in responsive designs and has no dependencies.
https://refreshless.com/nouislider/
MIT License
5.7k stars 657 forks source link

Slider Input Not Full Component Width (Regression in 15.5) #1214

Closed kdagnan closed 2 years ago

kdagnan commented 2 years ago

Not sure how to word this (videos below), but essentially our slider input can only be dragged in a small portion of the displayed slider. The range/steps are the same as expected, but for some reason don't take up the full width of the component.

Works as intended in 15.4: https://user-images.githubusercontent.com/44090970/181095668-7da03df5-5ae0-4fb1-9020-bad55512e8a0.mov

Behavior seen in 15.5 or greater: https://user-images.githubusercontent.com/44090970/181095679-aeb37932-39a1-452b-ad50-275297268672.mov

Any ideas what could have changed this behavior and/or what I can do to fix it?

Didn't provide any implementation details because we're quite literally just passing standard options (min, max, step, start, etc) to noUiSlider.create. Other components are just aligned properly to make it look fancy on top. We copy/pasted the default styles at some point (and are overriding separately as necessary), but it doesn't look like those have changed.

kdagnan commented 2 years ago

Update: Actually it was the minor css changes - Screen Shot 2022-07-26 at 2 57 56 PM

Release notes should point out stuff like that, I had to manually compare the branches & try the changes.

Thank you for a great package!

leongersen commented 2 years ago

Yeah, this is unfortunate; I'm sorry you ran into this issue. #1167 is open with some more discussion on this. I'll update the release notes to make this clearer.

github-actions[bot] commented 2 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.