leongersen / noUiSlider

noUiSlider is a lightweight, ARIA-accessible JavaScript range slider with multi-touch and keyboard support. It is fully GPU animated: no reflows, so it is fast; even on older devices. It also fits wonderfully in responsive designs and has no dependencies.
https://refreshless.com/nouislider/
MIT License
5.69k stars 656 forks source link

The arguments of the `set` method cannot be null #1271

Closed Vasily257 closed 6 months ago

Vasily257 commented 6 months ago

Hi! I think I've found a little problem: the arguments of the set method cannot be null, although this is a valid value according to the documentation: https://refreshless.com/nouislider/slider-read-write/#section-setting

A temporary solution — to pass a 'null'.

P.S. Thanks for the awesome slider!

export interface API {
    destroy: () => void;
    steps: () => NextStepsForHandle[];
    on: (eventName: string, callback: EventCallback) => void;
    off: (eventName: string) => void;
    get: (unencoded?: boolean) => GetResult;

    // The null value should be allowed here
    set: (input: number | string | (number | string)[], fireSetEvent?: boolean, exactInput?: boolean) => void;

    setHandle: (handleNumber: number, value: number | string, fireSetEvent?: boolean, exactInput?: boolean) => void;
    reset: (fireSetEvent?: boolean) => void;
    disable: (handleNumber?: number) => void;
    enable: (handleNumber?: number) => void;
    options: Options;
    updateOptions: (optionsToUpdate: UpdatableOptions, fireSetEvent: boolean) => void;
    target: HTMLElement;
    removePips: () => void;
    removeTooltips: () => void;
    getTooltips: () => {
        [handleNumber: number]: HTMLElement | false;
    };
    getOrigins: () => {
        [handleNumber: number]: HTMLElement;
    };
    pips: (grid: Pips) => HTMLElement;
}
leongersen commented 6 months ago

Thanks, you are quite right. I've update the types in noUiSlider 15.7.2.

github-actions[bot] commented 5 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.