search

leongersen / noUiSlider

noUiSlider is a lightweight, ARIA-accessible JavaScript range slider with multi-touch and keyboard support. It is fully GPU animated: no reflows, so it is fast; even on older devices. It also fits wonderfully in responsive designs and has no dependencies.
https://refreshless.com/nouislider/
MIT License
5.69k stars 657 forks source link

Updating 'start' eliminates serialization formatting #243

Closed hotmeteor closed 10 years ago

hotmeteor commented 10 years ago

I'm using the plugin with two handles for two drop downs.

On binding of the plugin, I set up some default serialization formatting and two Links per drop down. I've added a slide event to check the values and then update the slider accordingly should my values meet specific criteria.

All works as it should, however my text Links lose their formatting.

Pre-update they look like this: $169,900 Post-update they look like this: 169900

Any ideas?

leongersen commented 10 years ago

That seems wrong, I'll look into it. Thanks for reporting!

leongersen commented 10 years ago

Fixed in noUiSlider 6.1. The issue had nothing to do with the start option. Rebuilding failed to recognize inheritance for formatting options properly. Thanks for the report! I've added new unit tests to cover cases like these.

hotmeteor commented 10 years ago

Fantastic, thank you!

github-actions[bot] commented 2 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.