search

leonhard-s / auraxium

A high-level Python wrapper for the PlanetSide 2 API.
https://auraxium.readthedocs.io/
MIT License
28 stars 8 forks source link

outfit.leader() -> Character or OutfitMember #49

Closed dbrennand closed 3 years ago

dbrennand commented 3 years ago

Hi again 👋🏻

I'm using the outfit.leader() classmethod expecting to get the outfit leader's character data. The documentation says the object returned is Character:

image

But looking at the response it looks more like OutfitMember.

EDIT: Removed second issue, user error.

dbrennand commented 3 years ago

Oh my goodness, apologies. Forget the second issue. I forgot to await 🤦🏻

leonhard-s commented 3 years ago

Hi - that looks like a documentation error, the implementation does correctly type it as an OutfitMember instance. I pushed a correction, might take a few minutes for ReadTheDocs to update accordingly.

Thank you for the report - the new documentation system makes for pretty docs, but it does come with some extra steps that are hard to check in bulk. 👍