leonibr / community-extensions-cache-postgres

A PostgreSQL Implementation of IDistributedCache interface. Using Postgresql as distributed cache in Asp.Net Core. NetStandard 2.0
59 stars 17 forks source link

Irrelevant README's description #7

Closed Jenevra closed 3 years ago

Jenevra commented 3 years ago

Hi :)

I suppose that the description of your README document is a bit irrelevant.

It concerns this part (point 2):

services.AddDistributedPostgreSqlCache(setup => 
{
    ConnectionString = configuration["ConnectionString"], 
    SchemaName = configuration["SchemaName"],
    TableName = configuration["TableName"],
    RemoveExpiredDisabled = configuration["RemoveExpiredDisabled"],
    // Optional - RemoveExpiredDisabled default is FALSE
    CreateInfrastructure = configuration["CreateInfrastructure"] 
    // CreateInfrastructure is optional, default is TRUE
    // This means que every time starts the application the 
    // creation of table and database functions will be verified.
})

First of all, this parameter RemoveExpiredDisabled doesn't exist anymore. I guess now it's called DisableRemoveExpired. Also, the way it's all written is incorrect - need to add setup. before every parameter or new PostgreSqlCacheOptions() is missing.

leonibr commented 3 years ago

Hi, Thank you for pointing that out!

leonibr commented 3 years ago

@Jenevra could you please checkout branch fix#7, anything more you would like to add?

Jenevra commented 3 years ago

Oh, yeah, you also need to put ; instead of , after each row (sorry, forgot to mention it). And, I think, that's all)

leonibr commented 3 years ago

done, thanks